This repository was archived by the owner on Sep 4, 2025. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 15
bump ubi base image tag #24
Merged
openshift-merge-bot
merged 2 commits into
opendatahub-io:ibm_main
from
dtrifiro:bump-ubi-base-image-tag
May 15, 2024
Merged
bump ubi base image tag #24
openshift-merge-bot
merged 2 commits into
opendatahub-io:ibm_main
from
dtrifiro:bump-ubi-base-image-tag
May 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@dtrifiro I have rebased this branch. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro, z103cb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 16, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This PR makes the mypy suggested modifications to our code. --------- Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 16, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This PR makes the mypy suggested modifications to our code. --------- Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
heyselbi
pushed a commit
to heyselbi/vllm
that referenced
this pull request
Jul 7, 2024
Sync 2.11 with main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile.ubi: use 9.4 as base UBI tag