Rename project + Run in CI subset + Runtime formating #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has first seen with regions, but should be an issue with segments as well. What happened was that in revisit_written_pages, we determined the highest allocated address in a region, then obtained the dirty pages up to that high address. In parallel, another thread allocated a new object after the high address and wrote to it. The background GC thread saw the dirty page, but didn't explore the object because it was after its stale value for the high address. That caused some objects pointed at from the beginning of the new object to be seen as dead by background GC. Because the allocating thread also set the card table entries, the next ephemeral GC crashed because the references from the new object were now invalid. The fix is to refetch the high address after we have obtained the dirty pages. That way, we'll explore new objects allocated while we were getting the dirty pages. New objects allocated and written to after we obtained the dirty pages will cause more dirty pages and will thus be explored later. My repro case that caused about a crash every two hours or so has run overnight with this fix without issues.
…8803) * fix preheader removal * just check the fgBBNumMax
Ping.RawSocket his its own inline implementaion of this, maybe this should be consolidated somewhere? src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.RawSocket.cs L101
… to (dotnet#69087) the high-resource-aot build job.
We do not use this stack anywhere that uses the generic tree walker so avoid computing it.
* Echo the string into a local global.json. * Complete some final cleanup stuff.
* Update generators.targets Changes: - Improve perf of LibraryImportGenerator condition and simplify it - Use the same msbuild code styling as in other projects in src/libraries - Update comments that were outdated - Remove the item conditions for the regex source generator which doesn't work well with the CPS (common project system) inside VS. - Remove unnecessary property * Update eng/generators.targets Co-authored-by: Jeremy Barton <jbarton@microsoft.com> * Update generators.targets * Update generators.targets Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* skip test on ignoring Content-Length on browser * exclude test only from nodejs
Fix typo in AssemblyName handling and add test that catches the bug introduced by the typo
Fixes dotnet#68764 The in the above issue mentioned warnings are resolved by using VS 17.3 (currently Preview1).
…tnet#68964) * Updating BigInteger to implement the generic math interfaces * Adding generic math tests for BigInteger * Addressing PR feedback
Update `IsIconHandle` to work for all tree types. Closes dotnet#69032.
* Removing comments so won't overwrite doc changes * removing comments from two more places as directed
Fixes dotnet#29154. I didn't introduce a new target to keep the validation cost as low as possible.
…68956) * Don't return SslStreamBuffer when disposing during handshake * Update src/libraries/System.Net.Security/src/System/Net/Security/SslStream.IO.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
…ild 20220509.2 (dotnet#69131) Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.22252.2 -> To Version 1.1.0-alpha.0.22259.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Support strictly blittable type marshalling * Update design document. * Add test to validate check for blittability for assembly reference
…dotnet#69009) * Revert "Revert "[QUIC] Adopted msquic generated interop (dotnet#68288)" (dotnet#68940)" This reverts commit 4820674. * Exclude S.N.Quic from Mono AOT * Fix dotnet#68954
* StringMarshaller optimizations - Make the StringMarshallers smaller. They do not need to store the full stackallocated Span. - Use the stack allocated buffer more often. - Other fixes for consistency * Delete Utf16StringMarshaller constructor that takes caller allocated buffer * Update src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/Utf16StringMarshaller.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>
- Add PGO for arm64 - Switch to using compiler container images which support PGO compilation on Arm64
* Fix native sourcelink support * Correctly case Sdk.Targets Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
* Update NoTargets SDK and clean-up code microsoft/MSBuildSdks@9af7ea2 is merged so we can now clean-up the symbol properties that were set to disable the pdb feature. * Update NoTargetsSdk.BeforeTargets.targets
* Fix typos * Fix typo: seperate -> separate * Rename ApplicationNameSetFromArgument * Update src/coreclr/vm/methodtablebuilder.cpp * Update docs/coding-guidelines/clr-code-guide.md Co-authored-by: Dan Moseley <danmose@microsoft.com> * Update src/mono/mono/tests/verifier/make_tests.sh Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fix fcmp
* Revert unwanted change
* Add a new enum value for LLVMRealUEQ
* Remove extra declaration
* Remove simd intrinsics support for Vector<T>.Equals and Vector{64,128}<T>.Equals, since there isn't an intrinsics matching .NET behavior
* Remove leftover unwanted change
* Remove the Equals intrinsic for Vector4
* Remove unused var
…tnet/icu dotnet/xharness dotnet/runtime-assets dotnet/emsdk dotnet/msquic (dotnet#69127) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <lewing@microsoft.com>
If a branch predicate `p` is dominated by another branch with predicate `AND(p, ..)` or `OR(p, ...)` we may be able to infer the value of `p`. This is useful on its own, and should help unblock dotnet#62689.
Add project to be executed in CI Change files to have runtime format
This adds support for EnC on arm64. A couple of notes on the implementation compared to x64: - On x64 we get the fixed stack size from unwind info. However, for the frames we set up on arm64 for EnC it is not possible to extract the frame size from there because their prologs generally look like stp fp, lr, [sp,#-16]! mov fp, sp sub sp, sp, dotnet#144 with unwind codes like the following: set_fp; mov fp, sp save_fplr_x dotnet#1 (0x01); tp fp, lr, [sp, #-16]! As can be seen, it is not possible to get the fixed stack size from unwind info in this case. Instead we pass it through the GC info that already has a section for EnC data. - On arm64 the JIT is required to place the PSPSym at the same offset from caller-SP for both the main function and for funclets. Due to this we try to allocate the PSPSym as early as possible in the main function and we must take some care in funclets. However, this conflicts with the EnC frame header that the JIT uses to place values that must be preserved on EnC transitions. This is currently callee-saved registers and the MonitorAcquired boolean. Before this change we were allocating PSPSym above (before) the monitor acquired boolean, but we now have to allocate MonitorAcquired first, particularly because the size of the preserved header cannot change on EnC transitions, while the PSPSym can disappear or appear. This changes frame allocation slightly for synchronized functions.
…otnet#69615) * [wasm] don't fail the job if firefox debugger tests fail, as they are known to be unstable currently * Trying feedback * Revert "Trying feedback" This reverts commit 849760c.
Bring RequiresTests Bring GetDisplayNameTests Modify DisplayNameHelpers for Generic printing
vitek-karas
pushed a commit
that referenced
this pull request
Jun 29, 2022
* Initial implementation for contract customization fix build errors Move converter rooting to DefaultJsonTypeInfoResolver so that it can be used standalone Fix ConfigurationList.IsReadOnly Minor refactorings (#1) * Makes the following changes: * Move singleton initialization for DefaultTypeInfoResolver behind a static property. * Consolidate JsonSerializerContext & IJsonTypeInfoResolver values to a single field. * Move reflection fallback logic away from JsonSerializerContext and into JsonSerializerOptions * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs * remove testing of removed field Simplify the JsonTypeInfo.CreateObject implemenetation (#2) * Simplify the JsonTypeInfo.CreateObject implemenetation * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.cs * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.cs Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com> Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com> Tests and fixes for JsonTypeInfoKind.None TypeInfo type mismatch tests Allow setting NumberHandling on JsonTypeInfoKind.None test resolver returning wrong type of options JsonTypeInfo/JsonPropertyInfo mutability tests rename test file Move default converter rooting responsibility behind DefaultJsonTypeInfoResolver (#3) * Move default converter rooting responsibility behind DefaultJsonTypeInfoResolver * address feedback Add simple test for using JsonTypeInfo<T> with APIs directly taking it fix and tests for untyped/typed CreateObject uncomment test cases, remove todo More tests and tiny fixes Add a JsonTypeInfoResolver.Combine test for JsonSerializerContext (#4) * Fix JsonTypeInfoResolver.Combine for JsonSerializerContext * Break up failing test Fix simple scenarios for combining contexts (#6) * Fix simple scenarios for combining contexts * feedback JsonSerializerContext combine test with different camel casing Remove unneeded virtual calls & branching when accessing Get & Set delegates (#7) JsonPropertyInfo tests everything minus ShouldSerialize & NumberHandling Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs throw InvalidOperationException rather than ArgumentNullException for source gen when PropertyInfo.Name is assigned through JsonPropertyInfoValues tests for duplicated property names and JsonPropertyInfo.NumberHandling Add tests for NumberHandling and failing tests for ShouldSerialize disable the failing test and add extra checks disable remainder of the failing ShouldSerialize tests, fix working one Fix ShouldSerialize and IgnoreCondition interop Add failing tests for CreateObject + parametrized constructors Fix CreateObject support for JsonConstructor types (#10) * Fix CreateObject support for JsonConstructor types * address feedback Make contexts more combinator friendly (#9) * Make contexts more combinator friendly * remove converter cache * redesign test to account for JsonConstructorAttribute * Combine unit tests * address feedback * Add acceptance tests for DataContract attributes & Specified pattern (#11) * Add private field serialization acceptance test (dotnet#13) * tests, PR feedback (dotnet#14) * PR feedback and extra tests * Shorten class name, remove incorrect check (not true for polimorphic cases) * Make parameter matching for custom properties map property Name with parameter (dotnet#16) * Test static initialization with JsonTypeInfo (dotnet#17) * Fix test failures and proper fix this time (dotnet#18) * Fix test failures and proper fix this time * reinstate ActiveIssueAttribute * PR feedback and adjust couple of tests which don't set TypeInfoResolver * fix IAsyncEnumerable tests * Lock JsonSerializerOptions in JsonTypeInfo.EnsureConfigured() Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com> Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
vitek-karas
pushed a commit
that referenced
this pull request
May 18, 2023
vitek-karas
pushed a commit
that referenced
this pull request
Jun 12, 2023
…tnet#87189) This fixes a startup crash on Big Sur: > error: * Assertion at /Users/runner/work/1/s/src/mono/mono/utils/mono-hwcap-arm64.c:35, condition `res == 0' not met Because sysctl can't find some of these options: $ sysctl hw.optional.armv8_crc32 hw.optional.armv8_crc32: 1 $ sysctl hw.optional.arm.FEAT_RDM sysctl: unknown oid 'hw.optional.arm.FEAT_RDM' $ sysctl hw.optional.arm.FEAT_DotProd sysctl: unknown oid 'hw.optional.arm.FEAT_DotProd' $ sysctl hw.optional.arm.FEAT_SHA1 sysctl: unknown oid 'hw.optional.arm.FEAT_SHA1' $ sysctl hw.optional.arm.FEAT_SHA256 sysctl: unknown oid 'hw.optional.arm.FEAT_SHA256' $ sysctl hw.optional.arm.FEAT_AES sysctl: unknown oid 'hw.optional.arm.FEAT_AES' Full stack trace: * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 2.1 * frame #0: 0x0000010ef37560 libmonosgen-2.0.dylib`monoeg_assertion_message frame #1: 0x0000010ef375cc libmonosgen-2.0.dylib`mono_assertion_message + 32 frame #2: 0x0000010ef40d6c libmonosgen-2.0.dylib`mono_hwcap_arch_init + 544 frame #3: 0x0000010ef54bd8 libmonosgen-2.0.dylib`mono_hwcap_init + 72 frame #4: 0x0000010ee14dc0 libmonosgen-2.0.dylib`parse_optimizations + 52 frame #5: 0x0000010edbed48 libmonosgen-2.0.dylib`mono_init frame #6: 0x0000010ee18968 libmonosgen-2.0.dylib`mono_jit_init_version frame #7: 0x0000010f48a300 libxamarin-dotnet-debug.dylib`xamarin_bridge_initialize + 216 frame #8: 0x0000010f4900a4 libxamarin-dotnet-debug.dylib`xamarin_main + 376
vitek-karas
pushed a commit
that referenced
this pull request
Aug 21, 2023
vitek-karas
pushed a commit
that referenced
this pull request
Nov 15, 2023
…tnet#90436) * Enable IL trim for WASM by default * Make ILStrip available for local build * Make all calling another method go through the logic to see if it could call an AOT'ed version of it before trying to interp compile it * Add back accidentally removed line of code * Update test to accommodate IL trim with WASM AOT * Move jit_call_can_be_supported to mini-runtime, so it doesn't depends on the value of mono_use_interpreter * Update var name * Attempt to fix rebuild test failures * Attempt to fix the file open issue with unicode on windows * Attempt to fix unicode issue #2 * Enable g_fopen to have the capability of handling opening files with unicode name on all platforms * Add comment * Update comment * Fix file indentation format * Check if string contains non-ascii char * Remove unused callback * Remove redundant comment * Update method name * Fixed some method not found issues and remove the optimization for g_fopen * Fix tailcall * Disable tailcall optimization when calling a trimmed method * Free method header * Fix windows build error * Free method header at the correct locatioin * Fix the condition of skipping tailcall * Fix test failure * Move JIT/AOT call invoke away from MINT_CALL, as it is not needed there. * Fix virtual tail call * Address review feedback * Put the trimmed assemblies in a new folder, output an updated list of assemblies and update _WasmAssembliesInternal with the new list * Put trimmed assemblies in IntermediateOutputPath * Remove TrimmedAssemblies * Create trimmed assembly folder before the parallel run * Try to fix the issue with missing item * Fix parallelism issue * Only start the trim when the assembly is newer than the output * Add assembly item to the list, when * Add some logging * Fixed runtimeconfig.json file path issue and disabed failed tests * Update parameter name * Fix wasi build * Use the correct parameter * Fix runtime test failure * WasmAppBuilder: runtimeconfig.json path can be null * cleanup * ILStrip: fix typo in id name * Cleanup * ILStrip: ensure output assemblies are in the same order as the input. This is required for incremental builds. * more cleanup * Re-enable disabled tests * Change the default value for WasmStripILAfterAOT to false * Fix the issue with changing the value of WasmStripILAfterAOT between incremental builds * Move the location of file deleting * Use WasmAssembliesFinal or ResolvedFileToPublish during publish in WasmSDK * Copy metadata in AOT compiler and when creating WasmAssembliesToBundle from ResolvedFileToPublish * Add _WasmSatelliteAssemblies to WasmAssembliesFinal * Add a wasm template test * Include all non-dll ResolvedFileToPublish for ComputeWasmPublishAssets * Add a blazor template test * Address review feedback * Update src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Update parameter name * Update usage of parameter * Revert EmccCompile change * MonoAOTCompiler: revert rebuilding when WasmStripILAfterAOT value changes * Compress -> GZipCompress, and cleanup * rework the tests - to support webcil case - run blazor app - add cases for the default setting, and the opposite - cleanup * ILStrip.cs: Emit a message about stripping to make it obvious to the user * WasmApp.targets: update comment * Change default value to false and update test --------- Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Marek Fišera <mara@neptuo.com>
vitek-karas
pushed a commit
that referenced
this pull request
Dec 4, 2023
Fixes dotnet#95367. Relevant part of the JitDump: ``` Using `if true` assertions from pred BB02 Assertions in: #1 fgMorphTree BB04, STMT00021 (before) [000070] DA--------- * STORE_LCL_VAR ubyte V10 tmp9 [000057] ----------- \--* CAST int <- ubyte <- int [000006] ----------- \--* EQ int [000004] ----------- +--* LCL_VAR ref V02 tmp1 (last use) [000055] H---------- \--* CNS_INT(h) ref 'Frozen EmptyPartition`1<Int32> object' Assertion prop for index #1 in BB04: [000006] ----------- * EQ int GenTreeNode creates assertion: [000070] DA---+----- * STORE_LCL_VAR ubyte V10 tmp9 In BB04 New Local Constant Assertion: V10 == [0000000000000001], index = #2 fgMorphTree BB04, STMT00021 (after) [000070] DA---+----- * STORE_LCL_VAR ubyte V10 tmp9 [000055] H----+----- \--* CNS_INT(h) int ``` The JitDump is unfinished because the compiler crashes when trying to dump the last line. Clearly, the `CNS_INT` is no longer a handle at that point because we just bashed it to a constant 1.
vitek-karas
pushed a commit
that referenced
this pull request
Mar 8, 2024
vitek-karas
pushed a commit
that referenced
this pull request
Jul 16, 2024
* [wasm] Bump emscripten to 3.1.56 * Replace Module.asm with Module.wasmExports Module.asm was removed, use wasmExports instead. Context: emscripten-core/emscripten#19816 * Updates for .native.worker.js -> mjs rename Context: emscripten-core/emscripten#21041 * Update deps * Add general testing feed * Update mode deps * Update path * Use current python packages for now, we don't have newer ones The current names 3.1.34 are new enough * Keep using llvm 16 for runtime and aot compiler * Add -Wno-pre-c11-compat only for browser * Temporarily disable version checks to get further * Temporarily disable version checks to get further #2 * Disable -Wunused-command-line-argument * Update emsdk deps * Update icu dependency * Revert "Temporarily disable version checks to get further #2" This reverts commit 3f8834f. * Revert "Temporarily disable version checks to get further" This reverts commit fe1e5c6. * Fix emsdk check We use system python on osx too * Workaround wasm-opt crash * Workaround wasm-opt crash * Workaround wasm-opt crash * Fix WBT test * Feedback * Update ICU dependency * Update emscripten deps * Revert "Workaround wasm-opt crash" This reverts commit 200cf3b. * Revert "Workaround wasm-opt crash" This reverts commit 4530edf. * Revert "Workaround wasm-opt crash" This reverts commit 3593c41. * Increase tests timeout * Show test progress * Increase MT library tests timeout * Disable WBT tests with SkiaSharp * Increase helix tests timeout on browser * Increase WBT timeout * Increase initial heap sizes * Fix mono_wasm_load_runtime cwrap signature Fixes: `Uncaught ExitStatus: Assertion failed: stringToUTF8Array expects a string (got number)` * Enable XunitShowProgress for threading tasks tests * Try to reduce number of parallel AOT compilations To check whether it will improve memory issues on CI * Use new docker image for helix/windows tests * Revert "Try to reduce number of parallel AOT compilations" This reverts commit 5d9a6d2. * Reduce the timeouts * Reduce intitial heap size * use active issues for MT * Remove testing channel from nuget config, update deps * Update emsdk and icu dependencies --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: pavelsavara <pavel.savara@gmail.com>
vitek-karas
pushed a commit
that referenced
this pull request
Oct 10, 2024
* bug #1: don't allow for values out of the SerializationRecordType enum range * bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type * bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use) * bug #4: document the fact that IOException can be thrown * bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails * bug #6: 0 and 17 are illegal values for PrimitiveType enum * bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename ILLink.Tests* to Mono.Linker.Tests*
Add project to be executed in CI
Change files to have runtime format