JSON contract customization #70435

krwq · 2022-06-08T14:47:59Z

Implements: #63686

ghost · 2022-06-08T14:48:10Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2022-06-08T14:48:14Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds contract customization.

This is WIP, it's easier to create comments and track remaining work this way

Author:	krwq
Assignees:	krwq
Labels:	`area-System.Text.Json`, `new-api-needs-documentation`
Milestone:	-

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs

src/libraries/System.Text.Json/src/System/Text/Json/JsonPropertyDictionary.ValueList.cs

...libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/CastingConverter.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs

...ystem.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.HandlePropertyName.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

.../System.Text.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.cs

...braries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonMetadataServices.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfoOfT.cs

....Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonPropertyInfo.cs

...stem.Text.Json/tests/System.Text.Json.Tests/Serialization/TypeInfoResolverFunctionalTests.cs

....Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonPropertyInfo.cs

eiriktsarpalis · 2022-06-21T02:51:24Z

I think we need to add more tests for collection and dictionary metadata. Current set seems too focused on objects only.

eiriktsarpalis · 2022-06-21T02:51:55Z

FWIW I ran the benchmark suite comparing the PR branch with the base commit and found no regressions. We should be good on that front.

…11)

....Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonPropertyInfo.cs

* PR feedback and extra tests * Shorten class name, remove incorrect check (not true for polimorphic cases)

…parameter (#16)

* Fix test failures and proper fix this time * reinstate ActiveIssueAttribute * PR feedback and adjust couple of tests which don't set TypeInfoResolver * fix IAsyncEnumerable tests * Lock JsonSerializerOptions in JsonTypeInfo.EnsureConfigured() Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>

krwq requested a review from eiriktsarpalis June 8, 2022 14:47

ghost assigned krwq Jun 8, 2022

ghost added area-System.Text.Json new-api-needs-documentation labels Jun 8, 2022