Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 PGO Builds #66867

Merged
merged 7 commits into from
May 11, 2022
Merged

Add Arm64 PGO Builds #66867

merged 7 commits into from
May 11, 2022

Conversation

davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Mar 18, 2022

  • Add PGO for arm64
  • Switch to using compiler container images which support PGO compilation on Arm64

@ghost
Copy link

ghost commented Mar 18, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add PGO for arm64

  • This initial PR is not to be checked in as it adds the PGO to the PR build, which isn't needed long term, but I need to test it before merging the official build change.

Author: davidwrighton
Assignees: davidwrighton
Labels:

area-Infrastructure-libraries

Milestone: -

@deeprobin
Copy link
Contributor

I guess this will just fail due to an infrastructure problem https://github.com/dotnet/core-eng/issues/15812.

@ghost
Copy link

ghost commented Apr 15, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Apr 30, 2022

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Apr 30, 2022
@davidwrighton
Copy link
Member Author

The underlying problems with Linux arm64 compilation have been fixed, re-opening the PR.

@davidwrighton davidwrighton reopened this May 5, 2022
@ghost ghost removed the no-recent-activity label May 5, 2022
@davidwrighton davidwrighton requested review from janvorli and hoyosjs and removed request for janvorli May 10, 2022 23:48
@davidwrighton davidwrighton marked this pull request as ready for review May 10, 2022 23:48
@davidwrighton
Copy link
Member Author

@hoyosjs is there any way to have confidence this won't bork the official build? I've had the changes run in a PR job, and that passed, but I've now removed that logic (as we don't want PGO compilation to happen in PR).

@hoyosjs
Copy link
Member

hoyosjs commented May 10, 2022

@hoyosjs
Copy link
Member

hoyosjs commented May 11, 2022

The internal job LGTM WRT to the PGO changes.

@davidwrighton davidwrighton merged commit b3de8f7 into dotnet:main May 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
@davidwrighton davidwrighton deleted the pr_MorePGO branch April 13, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants