Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 installation fails due to dependency #4408

Closed
tux-rampage opened this issue Oct 23, 2020 · 3 comments
Closed

PHP 8 installation fails due to dependency #4408

tux-rampage opened this issue Oct 23, 2020 · 3 comments

Comments

@tux-rampage
Copy link
Contributor

This is more an upstream bug, but psalm is not installable with composer on PHP8 at the moment.
It requires webmozart/glob which does not support PHP 8 by its composer php require constraint.

There is a PR on the required Package webmozarts/glob#19 - but no EST when this will be fixed.
@psalm-github-bot
Copy link

Hey @tux-rampage, can you reproduce the issue on https://psalm.dev ?

@tux-rampage tux-rampage mentioned this issue Oct 23, 2020
Merged
@muglug
Copy link
Collaborator

muglug commented Oct 24, 2020

I can make it instead a suggestion, with the enhanced glob functionality conditional on having that package. A minor setback tbh.

@muglug muglug closed this as completed in 949891a Oct 25, 2020
@muglug
Copy link
Collaborator

muglug commented Oct 25, 2020

Turns out it wasn't even being used...

@Jean85 Jean85 mentioned this issue Oct 29, 2020
Merged
danog pushed a commit to danog/psalm that referenced this issue Jan 29, 2021
@muglug @danog
Don’t require webmozart/glob
2665b7e 
Fixes vimeo#4408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tux-rampage @muglug