Authorize installation on PHP8 #19
Conversation
|
Hi @webmozart ! I know you are probably busy but this one can be quickly merged IMO |
|
@Th3Mouk thanks! Could you take care of the failing builds? |
|
@webmozart I took the configuration of |
| allow_failures: | ||
| - php: hhvm |
There was a problem hiding this comment.
This should be added back. Tests will silently fail HHVM as they did previously. See this job from master branch: https://travis-ci.org/github/webmozart/glob/jobs/152415050
| env: | ||
| - COVERAGE=yes | ||
| - ANALYSIS=yes | ||
| - php: 7.4 |
There was a problem hiding this comment.
I think tests should be performed on PHP 8 as well.
There was a problem hiding this comment.
nightly is php 8 but it exists probably a better tag now
There was a problem hiding this comment.
As an alternative, tests could be moved to GitHub actions. See https://github.com/yiisoft/strings/tree/master/.github/workflows as an example. There, you'll have PHP 8 beta. But, that's better to be done separately.
There was a problem hiding this comment.
I saw many projects doing this, this month. We are on GA too in my projects. But I think we must first resolve PHP8 installation/CI and then refacto the CI process
There was a problem hiding this comment.
Travis isn't giving enough credits to OpenSource anymore so a switch to GitHub actions is inevitable.
There was a problem hiding this comment.
This could be done separately, it's not related to this PR.
There was a problem hiding this comment.
Then it's ready to merge except https://github.com/webmozart/glob/pull/19/files#r511509629 should be applied.
No description provided.