Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Support #1087

Merged
merged 48 commits into from
Dec 5, 2020
Merged

PHP 8 Support #1087

merged 48 commits into from
Dec 5, 2020

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Sep 13, 2020

This is temporarily blocked by Jean85/pretty-package-versions#25 (which in turn is blocked by phpspec/prophecy#491)

@Jean85
Copy link
Collaborator Author

Jean85 commented Sep 15, 2020

Closing/reopening to trigger CI restart.

@Jean85 Jean85 closed this Sep 15, 2020
@Jean85 Jean85 reopened this Sep 15, 2020
@ste93cry ste93cry mentioned this pull request Oct 27, 2020
@ste93cry
Copy link
Collaborator

I think that phpspec/prophecy has been updated to support PHP 8, can you please rebase the PR and check if everything works?

@ste93cry ste93cry added this to the 3.0 milestone Oct 27, 2020
@ste93cry
Copy link
Collaborator

Please don't merge the branch on the PR but rebase instead to keep the history cleaner 😉 Also build is failing due to PHPStan

@Jean85
Copy link
Collaborator Author

Jean85 commented Oct 27, 2020

History is not an issue since we do squash+merge; I prefer merges since they create less issues with conflicts.

PHPStan issue fixed.

@Jean85
Copy link
Collaborator Author

Jean85 commented Oct 29, 2020

Blocked by vimeo/psalm#4408 (which is already fixed but unreleased)

@Jean85
Copy link
Collaborator Author

Jean85 commented Oct 29, 2020

Also, I can't reproduce current failures locally 😢

@chris-doehring
Copy link

chris-doehring commented Dec 3, 2020

The PHP-Parser package released a new version v4.10.3 including nikic/PHP-Parser#736, but unfortunately Travis CI still keeps failing. The main reason is the "Segmentation fault" error. At this point, I think this is a problem in the Travis environment. When running the same tests locally or via GitHub actions, this error does not occur. I don't know if you want to stick with Travis here, but if not, feel free to use the GitHub actions I created in my fork.

However, apart from the CI stuff, there is still one issue pending:
As soon as xdebug code coverage is activated, the test tests/phpt/error_handler_captures_out_of_memory_fatal_error.phpt does not call the shutdown function whenever it runs out of memory. This only happens for the highest dependencies, but so far I have no clue what the issue might cause.

@Jean85
Copy link
Collaborator Author

Jean85 commented Dec 4, 2020

Travis got its PHP 8 images!

I'll try one more run...

@chris-doehring
Copy link

I'm a bit surprised that the memory test was so easy to fix, but it makes a lot of sense that newer phpunit versions just use more memory when running with code coverage. I didn't think of that 😄 Nice work @ste93cry! If you now change the php 8 Travis image to 8.0snapshot, Travis should be completely green. 🥳 They are still working on a php 8.0 tag.

@ste93cry ste93cry marked this pull request as ready for review December 5, 2020 21:39
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work on this, excellent 💪

Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to everyone that contributed the changes to make this PR work and thank you all for the patience. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants