Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless code left from old implementation #736

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Remove useless code left from old implementation #736

merged 1 commit into from
Dec 2, 2020

Conversation

ste93cry
Copy link
Contributor

@ste93cry ste93cry commented Dec 1, 2020

As per title, fixes #735

@ste93cry ste93cry mentioned this pull request Dec 1, 2020
Merged
@nikic nikic merged commit bc7a9bf into nikic:master Dec 2, 2020
@ste93cry ste93cry deleted the fix/cleanup-useless-code branch December 2, 2020 11:55
Jean85 added a commit to getsentry/sentry-php that referenced this pull request Dec 4, 2020
@Jean85
Requier nikic/php-parser ^4.10.3 due to nikic/PHP-Parser#736
1749fe8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the Lexer class in a shutdown function makes the last fatal error lost
2 participants
@ste93cry @nikic