Using the Lexer class in a shutdown function makes the last fatal error lost

[ste93cry]

While trying to debug some failing tests of the getsentry/sentry-php package I found out that PHPUnit since a while calls the parser with non-emulative lexing and that that code is executed inside a register_shutdown_function callback. Unluckily, the Lexer::startLexing() method calls error_clear_last() which clears the last catched fatal error and thus the next callback does not know anything about it anymore. I cannot find any call to error_get_last() in the source code and so I cannot think about what is the purpose of clearing the error, so I was wondering if it would be possible to remove that function call

[nikic]

This is a leftover from an earlier implementation that did use error_get_last(). It should be fine to drop the call now.

[ste93cry]

Do you plan to release a patch version soon? This issue is blocking one project I'm contributing to because the tests are broken

[nikic]

@ste93cry Done!