RSDK-13299 — Log occasional warning when capture data is stale#5745
Open
n0nick wants to merge 2 commits intoviamrobotics:mainfrom
Open
RSDK-13299 — Log occasional warning when capture data is stale#5745n0nick wants to merge 2 commits intoviamrobotics:mainfrom
n0nick wants to merge 2 commits intoviamrobotics:mainfrom
Conversation
Add a rate-limited WARN log to the disk summary tracker when the oldest file in the capture directory is older than 10x the sync interval (min 3 minutes). This surfaces when data is generating faster than it can be uploaded or when uploads are failing. The warning only fires when the sync scheduler is enabled and is rate-limited to once every 5 minutes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ytes - Replace static schedulerEnabled bool with a shouldSync(ctx) func that dynamically checks both SchedulerEnabled() and ReadyToSyncDirectories() - Log at WARN when sync should be active but data is stale; log at DEBUG when sync is paused (e.g. selective sync sensor returned false) - Remove duplicate formatBytes helper, use data.FormatBytesI64 instead - Export ReadyToSyncDirectories in sync package Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10 × sync_interval_mins(with a minimum of 3 minutes), and at most once every 5 minutesSchedulerEnabled()andReadyToSyncDirectories():data.FormatBytesI64for human-readable sizessync.Config.SchedulerEnabled()andsync.ReadyToSyncDirectories()Example log:
🤖 Generated with Claude Code