Skip to content

Conversation

@erh
Copy link
Member

@erh erh commented Oct 19, 2025

No description provided.

@erh erh requested a review from dgottlieb October 19, 2025 01:35
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 19, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Oct 28, 2025
mPoint := m.Pose().Point()
vec := mPoint.Sub(sPoint)

// Compute a perpendicular vector using cross product with a reference vector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments helped me understand a lot, thanks! I've pushed a higher level description above the triple for-loop.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

Availability

Scene # viamrobotics:main erh:20251917-cbirt-quick-mode Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 100% 100% 0%
6 91% 91% 0%
7 100% 100% 0%
8 100% 100% 0%
9 100% 100% 0%
10 100% 100% 0%
11 0% 0% NaN%

Quality

Scene # viamrobotics:main erh:20251917-cbirt-quick-mode Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 0% 71%
2 0.90±0.00 0.90±0.00 -0% 50%
3 6.15±0.45 6.30±0.71 -3% 43%
4 3.65±0.71 3.65±0.71 -0% 50%
5 12.55±5.52 12.14±5.37 3% 52%
6 10.54±2.47 10.38±2.40 2% 52%
7 6.23±2.75 6.23±2.75 -0% 50%
8 0.90±0.00 0.90±0.00 -0% 50%
9 4.32±0.22 4.23±0.17 2% 62%
10 12.83±0.39 12.83±0.39 -0% 50%
11 NaN±NaN NaN±NaN NaN% NaN%

Performance

Scene # viamrobotics:main erh:20251917-cbirt-quick-mode Percent Improvement Probability of Improvement Health
1 0.02±0.00 0.02±0.00 2% 53%
2 0.06±0.01 0.06±0.00 2% 56%
3 0.10±0.02 0.08±0.02 15% 68%
4 1.52±0.11 1.58±0.18 -3% 40%
5 3.87±2.73 3.23±1.51 17% 58%
6 3.36±1.07 3.25±1.27 3% 53%
7 3.53±0.95 3.62±1.12 -3% 47%
8 0.07±0.00 0.06±0.01 9% 69%
9 2.48±0.15 2.67±0.26 -8% 26%
10 6.88±1.22 6.93±1.34 -1% 49%
11 NaN±NaN NaN±NaN NaN% NaN%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: cec30ea73c0bdce713f1eb0295c930636f98e2f7
The SHA1 for erh:20251917-cbirt-quick-mode is: cec30ea73c0bdce713f1eb0295c930636f98e2f7

  • 11 samples were taken for each scene

@erh erh requested a review from dgottlieb November 8, 2025 05:19
@erh erh marked this pull request as draft November 8, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants