add motion get-pose to the cli #4945
Conversation
viambot
added
the
safe to test
| var commonPartFlags = []cli.Flag{ | ||
| &AliasStringFlag{ | ||
| cli.StringFlag{ | ||
| Name: generalFlagPart, | ||
| Aliases: []string{generalFlagPartID, generalFlagPartName}, | ||
| Required: true, | ||
| }, | ||
| }, | ||
| &AliasStringFlag{ | ||
| cli.StringFlag{ | ||
| Name: generalFlagOrganization, | ||
| Aliases: []string{generalFlagAliasOrg, generalFlagOrgID, generalFlagAliasOrgName}, | ||
| }, | ||
| }, | ||
| &AliasStringFlag{ | ||
| cli.StringFlag{ | ||
| Name: generalFlagLocation, | ||
| Aliases: []string{generalFlagLocationID, generalFlagAliasLocationName}, | ||
| }, | ||
| }, | ||
| &AliasStringFlag{ | ||
| cli.StringFlag{ | ||
| Name: generalFlagMachine, | ||
| Aliases: []string{generalFlagAliasRobot, generalFlagMachineID, generalFlagMachineName}, | ||
| }, | ||
| }, | ||
| } | ||
|
|
| Flags: append(commonPartFlags, []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: "component", | ||
| Required: true, | ||
| }, | ||
| }...), |
There was a problem hiding this comment.
We already have a component-name flag, is that not sufficient? I think generalizing the use of the existing flag (adding aliasing if necessary) is good for preventing bloat and ensuring consistency.
There was a problem hiding this comment.
I hate it.
it makes sense when it makes sense, but overuse creates issues too
There was a problem hiding this comment.
Can you elaborate? I don't need this to be a blocker and I'm happy to approve at this point but to my knowledge this will be the only instance of a flag with a name hard-coded like this as opposed to using a variable (or certainly the only intentional instance). I'd love to understand why for better maintaining the CLI going forward.
There was a problem hiding this comment.
Variables are good for things that change, where the string itself isn't important.
here, the string is literally the api.
No description provided.