merge from origin #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kazuhiro Sera <seratch@openai.com>
…ass to align with their documented behavior: (#1392)
- fix(litellm_model): Replace `Function` with `ChatCompletionMessageFunctionToolCall`. - Breaking change coming from https://github.com/openai/openai-python/releases/tag/v1.99.2 This pull request resolves the errors in #1396 Fixes #1395 Fixes #1401 --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com>
Add `__post_init__` validation to ensure Agent name is a string The Agent class previously only used type hints for the name field without runtime validation, allowing non-string values like integers to be passed. This caused downstream errors during JSON serialization, tracing, and other operations that expect the name to be a string. Changes: - Add `__post_init__` method to Agent class with `isinstance` check - Raise TypeError with descriptive message for non-string names - Validation occurs at instantiation time to fail fast Fixes issue where `Agent(name=1)` would succeed but cause errors later in the execution pipeline. Fixes #996
…oncurrent access in SQLiteSession (#1399)
This pull request adds a simple gpt-oss example app
## Summary Fixed a type safety issue where user input was being used as a string without conversion to integer, which could cause runtime errors and type mismatches. ## Problem The code was using `input()` which returns a string, but then using it directly in the f-string without converting it to an integer. This could cause: - Type mismatches when the string is passed to functions expecting integers - Runtime errors when users enter non-numeric input - Inconsistent behavior with the function signature expectations ## Changes Made Added proper input validation and type conversion: - Wrapped the input processing in a try-except block - Convert user input to integer using `int(user_input)` - Added error handling for invalid input with user-friendly message - Used the converted integer value in the f-string instead of raw string input This ensures type safety and provides better user experience with proper error handling.
Automated update of translated documentation Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This pull request migrates the translation script from o3 to gpt-5 model.
Automated update of translated documentation Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem with the current implementation, where for a single repsonse, we might have many different guardrails fire. We should have at most one per response.
Co-authored-by: Kazuhiro Sera <seratch@openai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
69 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.