Skip to content

feat: port ncc bundling pipeline to rspack #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ScriptedAlchemy wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: port ncc bundling pipeline to rspack #1304

ScriptedAlchemy wants to merge 11 commits into from

Conversation

@ScriptedAlchemy
Copy link

@ScriptedAlchemy ScriptedAlchemy commented Feb 9, 2026 •
edited
Loading

Summary

  • Port ncc's internal bundling pipeline from webpack to rspack while preserving CLI behavior.
  • Keep resolver fallback, native asset relocation, and TypeScript loader behavior aligned with existing edge cases.
  • Update unit output fixtures for rspack-generated artifacts and refresh dependencies/lockfile changes.

Testing

  • Updated fixture outputs across affected unit cases.
  • CI on this PR validates behavior against the existing test suite.

cursoragent and others added 8 commits February 9, 2026 04:22
@cursoragent @ScriptedAlchemy
Add rspack core dependency
dffd687 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Port ncc build to rspack
cee9fe1 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Fix resolver fallback and native asset handling
f743c42 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Update unit fixtures for Rspack output
19f1b19 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Remove esbuild dev dependency
a4989c4 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Harden rspack resolver fallback and ts-loader compatibility
c1079bb 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
chore: refresh lockfile after dependency cleanup
c0a5514 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@ScriptedAlchemy
Merge pull request #2 from ScriptedAlchemy/cursor/webpack-to-rspack-m…
0d8bd7d 
…igration-b0f7

Webpack to rspack migration
@socket-security
Copy link

socket-security bot commented Feb 9, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Added@​rspack/​core@​1.7.5951008097100
Updated@​vercel/​webpack-asset-relocator-loader@​1.7.3 ⏵ 1.10.098 +810010085100
Updatednode-gyp@​9.4.1 ⏵ 12.2.099100100 +191100

View full report

@ScriptedAlchemy ScriptedAlchemy changed the title feat: migrate to rspac feat: port ncc bundling pipeline to rspack Feb 9, 2026
ScriptedAlchemy and others added 2 commits February 9, 2026 12:48
@ScriptedAlchemy @cursoragent
chore: upgrade node-gyp for modern python compatibility
77dc5c7 
Update node-gyp to a Python 3.12+/3.13-compatible release so native test-binary builds work reliably in current macOS environments and no local workaround is required.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ScriptedAlchemy @cursoragent
Fix watch callback forwarding for changed and removed files
13294f5 
Handle both 4-argument and 5-argument watch callback signatures so changed and removed file sets are forwarded correctly and callbackUndelayed receives file metadata.

Co-authored-by: Cursor <cursoragent@cursor.com>
styfle
styfle reviewed Feb 10, 2026
View reviewed changes
scripts/build.js
minify,
cache,
v8cache,
externals: ["@vercel/webpack-asset-relocator-loader"]
Copy link
Member

@styfle styfle Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this dependency need to be external now?

styfle
styfle reviewed Feb 10, 2026
View reviewed changes
src/loaders/ts-loader.js
let sourceMapText;
let diagnostics = [];

module.exports = require("ts-loader");
Copy link
Member

@styfle styfle Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ts-loader is no longer used but its still in package.json

Is that expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styfle styfle styfle left review comments

@Timer Timer Awaiting requested review from Timer Timer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScriptedAlchemy @styfle @cursoragent