Skip to content

feat: port ncc bundling pipeline to rspack #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScriptedAlchemy wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: port ncc bundling pipeline to rspack #1304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dffd687
Add rspack core dependency
cursoragent Feb 9, 2026
cee9fe1
Port ncc build to rspack
cursoragent Feb 9, 2026
f743c42
Fix resolver fallback and native asset handling
cursoragent Feb 9, 2026
19f1b19
Update unit fixtures for Rspack output
cursoragent Feb 9, 2026
a4989c4
Remove esbuild dev dependency
cursoragent Feb 9, 2026
c1079bb
Harden rspack resolver fallback and ts-loader compatibility
cursoragent Feb 9, 2026
c0a5514
chore: refresh lockfile after dependency cleanup
cursoragent Feb 9, 2026
0d8bd7d
Merge pull request #2 from ScriptedAlchemy/cursor/webpack-to-rspack-m…
ScriptedAlchemy Feb 9, 2026
77dc5c7
chore: upgrade node-gyp for modern python compatibility
ScriptedAlchemy Feb 9, 2026
13294f5
Fix watch callback forwarding for changed and removed files
ScriptedAlchemy Feb 9, 2026
45bfde1
Merge branch 'main' into llms-module-rspack-port-78c2
styfle Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"@google-cloud/firestore": "^6.7.0",
"@sentry/node": "^7.66.0",
"@slack/web-api": "^6.9.0",
"@vercel/webpack-asset-relocator-loader": "1.7.3",
"analytics-node": "^6.2.0",
"apollo-server-express": "^2.2.2",
"arg": "^5.0.2",
Expand Down Expand Up @@ -72,7 +71,7 @@
"mkdirp": "^1.0.4",
"mongoose": "^8.8.3",
"mysql": "^2.16.0",
"node-gyp": "^9.4.0",
"node-gyp": "^12.2.0",
"npm": "^6.13.4",
"oracledb": "^6.1.0",
"passport": "^0.6.0",
Expand All @@ -99,7 +98,6 @@
"tiny-json-http": "^7.5.1",
"ts-loader": "^9.4.4",
"tsconfig-paths": "^4.2.0",
"tsconfig-paths-webpack-plugin": "^4.1.0",
"twilio": "^3.23.2",
"typescript": "^5.2.2",
"vm2": "^3.9.19",
Expand All @@ -109,5 +107,9 @@
"webpack": "5.94.0",
"when": "^3.7.8"
},
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"@rspack/core": "^1.7.5",
"@vercel/webpack-asset-relocator-loader": "^1.10.0"
}
}
9 changes: 8 additions & 1 deletion scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ async function main() {
__dirname + "/../src/index",
{
filename: "index.js",
externals: ["@rspack/core"],
minify,
cache,
v8cache
Expand All @@ -43,7 +44,13 @@ async function main() {

const { code: relocateLoader, assets: relocateLoaderAssets } = await ncc(
__dirname + "/../src/loaders/relocate-loader",
{ filename: "relocate-loader.js", minify, cache, v8cache }
{
filename: "relocate-loader.js",
minify,
cache,
v8cache,
externals: ["@vercel/webpack-asset-relocator-loader"]
Copy link
Member

@styfle styfle Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this dependency need to be external now?

}
);
checkUnknownAssets('relocate-loader', Object.keys(relocateLoaderAssets));

Expand Down
10 changes: 9 additions & 1 deletion src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,15 @@ async function runCmd (argv, stdout, stderr) {
});
return true;
} else {
return ncc.then(handler);
return ncc.then(handler).catch(err => {
stderr.write(err + '\n');
if (api) {
err.silent = true;
err.exitCode = 1;
throw err;
}
process.exit(1);
});
}
break;

Expand Down
Loading