Skip to content

Conversation

@ScriptedAlchemy
Copy link
Owner

Apply compatibility fixes and dependency cleanup to ensure full feature and test support for the Rspack migration.

This PR addresses three key compatibility risks identified during the Rspack migration review:

  1. Expanded missing-module fallback: The Rspack resolver hook's isNotFoundError logic was too narrow, only detecting "NotFound" errors. This has been expanded to include "Can't resolve" and "Cannot resolve" messages, restoring webpack-compatible fallback behavior for runtime not-found modules.
  2. Removed forced types: ["node"]: The custom TS loader was implicitly forcing types: ["node"], which could introduce unintended Node typings dependencies. This override has been removed to preserve compatibility with prior ts-loader semantics.
  3. Dependency hygiene: Several direct dev dependencies (@swc/core, @swc/wasm, @types/node, undici-types) were introduced during migration but are not required for NCC's core behavior. These have been removed from package.json and yarn.lock has been refreshed.

Validation against the main branch confirmed full parity, with 119 tests passing and only 2 known environment-limited native-module tests failing, matching main's baseline behavior.


Open in Cursor Open in Web

cursoragent and others added 2 commits February 9, 2026 19:57
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursor
Copy link

cursor bot commented Feb 9, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

⚠️ No Changeset found

Latest commit: c0a5514

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review February 9, 2026 20:05
@ScriptedAlchemy ScriptedAlchemy merged commit 0d8bd7d into cursor/llms-module-rspack-port-78c2 Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants