fix: set oci.ImageOptions.Ref to the correct value to ensure plugin charts are installed #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-ibra
changed the title
TylerGillson
previously approved these changes
Aug 1, 2024
ahmad-ibra
dismissed
TylerGillson’s stale review
The merge-base changed after approval.
ahmad-ibra
force-pushed
the
fix/oci-imageOpts-ref
branch
from
f799e6d
to
8fa643b
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 48.56% 55.35% +6.79%
==========================================
Files 22 21 -1
Lines 1287 1102 -185
==========================================
- Hits 625 610 -15
+ Misses 594 425 -169
+ Partials 68 67 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
force-pushed
the
fix/oci-imageOpts-ref
branch
from
f2ea177
to
2341428
Compare
ahmad-ibra
force-pushed
the
fix/oci-imageOpts-ref
branch
2 times, most recently
from
b882c27
to
e602df3
Compare
…an be pulled when stored on a private registry
ahmad-ibra
force-pushed
the
fix/oci-imageOpts-ref
branch
from
469f4cf
to
37ceb3f
Compare
TylerGillson
previously approved these changes
Aug 1, 2024
ahmad-ibra
added a commit
that referenced
this pull request
Aug 1, 2024
…harts are installed (#359) ## Description In validatorctl, when configuring a custom private registry, pulling the plugin charts fails with this error: ``` 2024-07-31 18:34:22 ERROR Plugin failed to install └ validator-plugin-network: failed to pull chart: failed to fetch image from registry: GET https://toolbox.palette-adv.spectrocloud.com/v2/ahmad/charts/validator-plugin-network/validator-plugin-network/manifests/0.0.21: NOT_FOUND: repository ahmad/charts/validator-plugin-network/validator-plugin-network not found ``` As can be seen above, there is an extra `/validator-plugin-network` tacked on at the end. This PR fixes that. This PR is a pre-requisite to validator-labs/validatorctl#115 ## Test Notes Tested this by: 1. running `helm install validator chart/validator/ -f chart/validator/values.yaml` 2. running `./bin/validator install` and configuring a plugin using the default registry (quay) 3. running `./bin/validator install` and configuring a plugin using a custom private registry (harbor) Everything runs correctly with this change. Prior to this change, test 3 was failing.
This was referenced Aug 1, 2024
ahmad-ibra
added a commit
that referenced
this pull request
Aug 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.50...v0.1.0) (2024-08-01) ### ⚠ BREAKING CHANGES * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ### Features * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ([6fe04ba](6fe04ba)) ### Bug Fixes * set oci.ImageOptions.Ref to the correct value to ensure plugin charts are installed ([#359](#359)) ([effd172](effd172)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Ahmad Malik Ibrahim <ahmad.ibrahim@spectrocloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In validatorctl, when configuring a custom private registry, pulling the plugin charts fails with this error:
As can be seen above, there is an extra
/validator-plugin-networktacked on at the end.This PR fixes that.
This PR is a pre-requisite to validator-labs/validatorctl#115
Test Notes
Tested this by:
helm install validator chart/validator/ -f chart/validator/values.yaml./bin/validator installand configuring a plugin using the default registry (quay)./bin/validator installand configuring a plugin using a custom private registry (harbor)Everything runs correctly with this change. Prior to this change, test 3 was failing.