refactor: create root level HelmConfig struct which applies to all HelmReleases #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-ibra
force-pushed
the
refactor/root-helm-config
branch
from
1c105fd
to
baee9b1
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 48.90% 48.56% -0.34%
==========================================
Files 22 22
Lines 1274 1287 +13
==========================================
+ Hits 623 625 +2
- Misses 584 594 +10
- Partials 67 68 +1
Continue to review full report in Codecov by Sentry.
|
… and existing HelmRelease struct
ahmad-ibra
force-pushed
the
refactor/root-helm-config
branch
from
fdabf73
to
36874a6
Compare
dosubot
bot
added
the
size:L
TylerGillson
previously approved these changes
Jul 30, 2024
ahmad-ibra
force-pushed
the
refactor/root-helm-config
branch
from
d3096b3
to
21fecb0
Compare
ahmad-ibra
force-pushed
the
refactor/root-helm-config
branch
from
21fecb0
to
47bd2a1
Compare
ahmad-ibra
force-pushed
the
refactor/root-helm-config
branch
from
47bd2a1
to
5153f7c
Compare
TylerGillson
approved these changes
Jul 31, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.51](v0.0.50...v0.0.51) (2024-07-31) ### Refactoring * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ([8eadfe1](8eadfe1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.51](v0.0.50...v0.0.51) (2024-07-31) ### Refactoring * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ([8eadfe1](8eadfe1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.51](v0.0.50...v0.0.51) (2024-07-31) ### Refactoring * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ([8eadfe1](8eadfe1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahmad-ibra
added a commit
that referenced
this pull request
Aug 1, 2024
…eleases (#356) First step into resolving - validator-labs/validatorctl#100 In an effort to simplify the TUI prompts in validatorctl to not require lots of re-prompts for the helm configuration, we first need to refactor our helm related structs. The proposed structure would be this: - `ValidatorConfigSpec.HelmConfig` defines the helm registry configuration that would be used to pull all plugin charts - `ValidatorConfigSpec.Plugins` has been simplifies to only specify the charts repository, name, version, and values. Along side this change, I updated the `reviewable-ext` make target to also update the CRDs in the validator helm chart
This was referenced Aug 1, 2024
ahmad-ibra
added a commit
that referenced
this pull request
Aug 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.50...v0.1.0) (2024-08-01) ### ⚠ BREAKING CHANGES * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ### Features * create root level HelmConfig struct which applies to all HelmReleases ([#356](#356)) ([6fe04ba](6fe04ba)) ### Bug Fixes * set oci.ImageOptions.Ref to the correct value to ensure plugin charts are installed ([#359](#359)) ([effd172](effd172)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Ahmad Malik Ibrahim <ahmad.ibrahim@spectrocloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
First step into resolving
Description
In an effort to simplify the TUI prompts in validatorctl to not require lots of re-prompts for the helm configuration, we first need to refactor our helm related structs.
The proposed structure would be this:
ValidatorConfigSpec.HelmConfigdefines the helm registry configuration that would be used to pull all plugin chartsValidatorConfigSpec.Pluginshas been simplifies to only specify the charts repository, name, version, and values.Along side this change, I updated the
reviewable-extmake target to also update the CRDs in the validator helm chart