Skip to content

Commit

Permalink
fix: set oci.ImageOptions.Ref to the correct value to ensure plugin c…
Browse files Browse the repository at this point in the history
…harts are installed (#359)

## Description
In validatorctl, when configuring a custom private registry, pulling the
plugin charts fails with this error:
```
2024-07-31 18:34:22 ERROR Plugin failed to install
                      └ validator-plugin-network: failed to pull chart: failed to fetch image from registry: GET https://toolbox.palette-adv.spectrocloud.com/v2/ahmad/charts/validator-plugin-network/validator-plugin-network/manifests/0.0.21: NOT_FOUND: repository ahmad/charts/validator-plugin-network/validator-plugin-network not found
```

As can be seen above, there is an extra `/validator-plugin-network`
tacked on at the end.
This PR fixes that.

This PR is a pre-requisite to
validator-labs/validatorctl#115

## Test Notes
Tested this by:
1. running `helm install validator chart/validator/ -f
chart/validator/values.yaml`
2. running `./bin/validator install` and configuring a plugin using the
default registry (quay)
3. running `./bin/validator install` and configuring a plugin using a
custom private registry (harbor)

Everything runs correctly with this change. Prior to this change, test 3
was failing.
  • Loading branch information
ahmad-ibra committed Aug 1, 2024
1 parent 9801b15 commit effd172
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion build
Submodule build updated 1 files
+3 −3 makelib/plugin.mk
Loading

0 comments on commit effd172

Please sign in to comment.