wstransport.nim: avoid re-raising 'TransportOsError' to avoid stopping switch.accept
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g `switch.accept` We found that a 'TransportOsError' can be raised by the next: https://github.com/status-im/nim-libp2p/blob/224f92e17251464984d6906316c54d2e1108ae43/libp2p/transports/wstransport.nim#L260 let req = await finished That 'TransportOsError' exception was re-raised in `wstransport` and caught by the `switch.accept` proc, which made the main accept loop to end accepting new upcoming connections because 'TransportOsError' is 'CatchableError'. https://github.com/status-im/nim-libp2p/blob/224f92e17251464984d6906316c54d2e1108ae43/libp2p/switch.nim#L277
Menduist
approved these changes
Jul 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #929 +/- ##
============================================
- Coverage 84.32% 83.45% -0.87%
============================================
Files 91 91
Lines 15001 15118 +117
============================================
- Hits 12649 12617 -32
- Misses 2352 2501 +149
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found that a 'TransportOsError' can be raised by the next:
https://github.com/status-im/nim-libp2p/blob/224f92e17251464984d6906316c54d2e1108ae43/libp2p/transports/wstransport.nim#L260
Then, that 'TransportOsError' exception was re-raised in
wstransportand caught by theswitch.acceptproc, which made the main accept loop end accepting new upcoming connections because 'TransportOsError' is 'CatchableError'.https://github.com/status-im/nim-libp2p/blob/224f92e17251464984d6906316c54d2e1108ae43/libp2p/switch.nim#L277
Impacted component
We saw the next problem in
nwaku: waku-org/nwaku#1831Future enhancements
#927