Skip to content

Refacto websocket upgrade #927

Open
Open

Description

WebSocket upgrade has an issue, the "websocket upgrade" is actually happening during the "accept" call currently.
This is bad, because it blocks the accept loop while we are upgrading a peer

Ideally, we would tweak nim-websock to split the "accept" & "upgrade" part, and then only call accept in accept, and upgrade in upgrade

Will also enable us to improve TransportOsError handling cc @Ivansete-status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status

      backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions