Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wstransport.nim: avoid re-raising 'TransportOsError' to avoid stopping switch.accept #929

Merged
merged 1 commit into from
Jul 7, 2023
Merged

wstransport.nim: avoid re-raising 'TransportOsError' to avoid stopping switch.accept #929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions libp2p/transports/wstransport.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,7 @@
except CancelledError as exc:
raise exc
except TransportOsError as exc:
info "OS Error", exc = exc.msg
raise exc
debug "OS Error", exc = exc.msg

Check warning on line 287 in libp2p/transports/wstransport.nim

View check run for this annotation

Codecov / codecov/patch

libp2p/transports/wstransport.nim#L287 

Added line #L287 was not covered by tests
except CatchableError as exc:
info "Unexpected error accepting connection", exc = exc.msg
raise exc
Expand Down