feat: fix shading in UPC to be less severe #1438

elibosley · 2025-06-25T19:14:55Z

Summary by CodeRabbit

Style
- Updated the banner gradient to match the full width of its container.
- Extended the gradient effect for a smoother visual transition across the banner.

coderabbitai · 2025-06-25T19:15:02Z

Walkthrough

The changes adjust the visual styling of a user profile banner by modifying the width of a gradient overlay in the component and extending the gradient's transition in the theme store. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
web/components/UserProfile.ce.vue	Updated the banner gradient container's width from 125% to 100% (`w-full`).
web/store/theme.ts, web/test/store/theme.test.ts	Modified the banner gradient's end stop from 30% to 90% in the CSS string and updated test snapshots accordingly.

Possibly related PRs

fix: connect breaks default css of header #1155: Refactors and enhances gradient variables and their application logic in the theme store, related to banner gradient styling changes.

Suggested reviewers

zackspear

Poem

A gradient now stretches far and wide,
No longer spilling past the side.
From thirty to ninety, colors blend,
A subtle shift, but on it depends
The look and feel of profile pride!
🌈

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e73b6e2 and c404dc0.

📒 Files selected for processing (2)

web/__test__/store/theme.test.ts (1 hunks)
web/store/theme.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

web/store/theme.ts

🧰 Additional context used

📓 Path-based instructions (4)

`web/**/*`: Always run pnpm codegen for GraphQL code generation in the web direc...

web/**/*: Always run pnpm codegen for GraphQL code generation in the web directory.
All GraphQL under web/ must follow this naming convention (.query.ts for queries, .mutation.ts for mutations).

📄 Source: CodeRabbit Inference Engine (CLAUDE.md)

List of files the instruction was applied to:

web/__test__/store/theme.test.ts

`web/__test__/**/*`: Tests are located under web/__test__, run with pnpm test.

web/__test__/**/*: Tests are located under web/test, run with pnpm test.

📄 Source: CodeRabbit Inference Engine (CLAUDE.md)

List of files the instruction was applied to:

web/__test__/store/theme.test.ts

`web/**/*`: Always run `pnpm codegen` for GraphQL code generation in the web dir...

web/**/*: Always run pnpm codegen for GraphQL code generation in the web directory
All GraphQL files under web/ must follow the naming convention: queries in .query.ts files and mutations in .mutation.ts files

📄 Source: CodeRabbit Inference Engine (.cursor/rules/web-graphql.mdc)

List of files the instruction was applied to:

web/__test__/store/theme.test.ts

`web/__test__/**/*.ts`: Use `mount` from Vue Test Utils for component testing, s...

web/__test__/**/*.ts: Use mount from Vue Test Utils for component testing, stub complex child components that aren't the focus of the test, and mock external dependencies and services.
Use createTestingPinia() for mocking stores in components when testing Vue components.
Use semantic queries like find('button') or find('[data-test="id"]') but prefer not to use data test IDs; use findComponent(ComponentName) for components.
Mock external services and API calls using vi.mock() for module-level mocks; specify return values for component methods with vi.spyOn(); reset mocks between tests with vi.clearAllMocks().
Use await nextTick() for DOM updates and flushPromises() for complex promise chains; always await async operations before making assertions.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/web-testing-rules.mdc)

List of files the instruction was applied to:

web/__test__/store/theme.test.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Build Web App
GitHub Check: Build Unraid UI Library (Webcomponent Version)
GitHub Check: Build API
GitHub Check: Test API
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

web/__test__/store/theme.test.ts (2)

83-83: Test assertion correctly updated for less severe gradient shading.

The gradient stop percentage change from 30% to 90% aligns with the PR objective to make banner shading less severe. The inline snapshot approach is appropriate for CSS string validation.

91-91: Test assertion correctly updated for background color case.

The gradient stop percentage change from 30% to 90% is consistent with the previous test case and maintains the less severe shading behavior for the background color scenario.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🔭 Outside diff range comments (1)

web/store/theme.ts (1)
56-63: Gradient stop now at 90 % – align all code paths

The computed bannerGradient now ends at 90 %, but the CSS variable set later in setCssVars() still hard-codes 30 %. This will produce two different gradients depending on which code path applies (style attr vs --banner-gradient variable).
-  customTheme['--banner-gradient'] = `linear-gradient(90deg, ${start} 0, ${end} 30%)`;
+  customTheme['--banner-gradient'] = `linear-gradient(90deg, ${start} 0, ${end} 90%)`;
Ideally extract the stop value into a constant to eliminate future drift.

🧹 Nitpick comments (1)

web/store/theme.ts (1)

100-115: DRY-up duplicated gradient logic

bannerGradient and setCssVars() duplicate start/end colour selection and the degree/stop logic. Factor this into a small helper like buildBannerGradient(start, end, stop = '90%') and reuse it in both places. This removes code duplication and prevents the type of inconsistency noted above.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17b7428 and e73b6e2.

📒 Files selected for processing (2)

web/components/UserProfile.ce.vue (1 hunks)
web/store/theme.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

`web/**/*`: Always run pnpm codegen for GraphQL code generation in the web direc...

web/**/*: Always run pnpm codegen for GraphQL code generation in the web directory.
All GraphQL under web/ must follow this naming convention (.query.ts for queries, .mutation.ts for mutations).

📄 Source: CodeRabbit Inference Engine (CLAUDE.md)

List of files the instruction was applied to:

web/store/theme.ts
web/components/UserProfile.ce.vue

`web/**/*`: Always run `pnpm codegen` for GraphQL code generation in the web dir...

web/**/*: Always run pnpm codegen for GraphQL code generation in the web directory
All GraphQL files under web/ must follow the naming convention: queries in .query.ts files and mutations in .mutation.ts files

📄 Source: CodeRabbit Inference Engine (.cursor/rules/web-graphql.mdc)

List of files the instruction was applied to:

web/store/theme.ts
web/components/UserProfile.ce.vue

`web/store/**/*.ts`: When testing Store files, use `createPinia()` and `setActiv...

web/store/**/*.ts: When testing Store files, use createPinia() and setActivePinia() for store setup; only use createTestingPinia if you specifically need its testing features.
Ensure Vue reactivity imports (computed, ref, watchEffect) are added to original store files, even if Nuxt auto-import is enabled.
Place all mock declarations at the top level and use factory functions for module mocks to avoid hoisting issues.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/web-testing-rules.mdc)

List of files the instruction was applied to:

web/store/theme.ts

🧠 Learnings (1)

web/store/theme.ts (1)

Learnt from: elibosley
PR: unraid/api#1155
File: web/store/theme.ts:161-172
Timestamp: 2025-02-20T15:52:58.297Z
Learning: The banner gradient implementation in web/store/theme.ts doesn't require explicit error handling for hexToRgba as CSS gracefully handles invalid values by ignoring them.

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Build API
GitHub Check: Build Web App
GitHub Check: Build Unraid UI Library (Webcomponent Version)
GitHub Check: Test API
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

web/components/UserProfile.ce.vue (1)

97-101: Verify visual overflow after switching to w-full

Changing width from w-[125%] to w-full reduces horizontal overhang. On some breakpoints the gradient previously extended beyond the card to hide edge artefacts; with full-width it might now stop short and expose the underlying background.

Please sanity-check on ≥ 2 k resolution & RTL layouts. If artefacts appear, consider keeping a slight over-width (e.g. w-[110%]) or removing the right-0 offset.

github-actions · 2025-06-25T19:25:14Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1438/dynamix.unraid.net.plg

🤖 I have created a release *beep* *boop* --- ## [4.9.0](v4.8.0...v4.9.0) (2025-07-08) ### Features * add graphql resource for API plugins ([#1420](#1420)) ([642a220](642a220)) * add management page for API keys ([#1408](#1408)) ([0788756](0788756)) * add rclone ([#1362](#1362)) ([5517e75](5517e75)) * API key management ([#1407](#1407)) ([d37dc3b](d37dc3b)) * api plugin management via CLI ([#1416](#1416)) ([3dcbfbe](3dcbfbe)) * build out docker components ([#1427](#1427)) ([711cc9a](711cc9a)) * docker and info resolver issues ([#1423](#1423)) ([9901039](9901039)) * fix shading in UPC to be less severe ([#1438](#1438)) ([b7c2407](b7c2407)) * info resolver cleanup ([#1425](#1425)) ([1b279bb](1b279bb)) * initial codeql setup ([#1390](#1390)) ([2ade7eb](2ade7eb)) * initialize claude code in codebse ([#1418](#1418)) ([b6c4ee6](b6c4ee6)) * move api key fetching to use api key service ([#1439](#1439)) ([86bea56](86bea56)) * move to cron v4 ([#1428](#1428)) ([b8035c2](b8035c2)) * move to iframe for changelog ([#1388](#1388)) ([fcd6fbc](fcd6fbc)) * native slackware package ([#1381](#1381)) ([4f63b4c](4f63b4c)) * send active unraid theme to docs ([#1400](#1400)) ([f71943b](f71943b)) * slightly better watch mode ([#1398](#1398)) ([881f1e0](881f1e0)) * upgrade nuxt-custom-elements ([#1461](#1461)) ([345e83b](345e83b)) * use bigint instead of long ([#1403](#1403)) ([574d572](574d572)) ### Bug Fixes * activation indicator removed ([5edfd82](5edfd82)) * alignment of settings on ManagementAccess settings page ([#1421](#1421)) ([70c790f](70c790f)) * allow rclone to fail to initialize ([#1453](#1453)) ([7c6f02a](7c6f02a)) * always download 7.1 versioned files for patching ([edc0d15](edc0d15)) * api `pnpm type-check` ([#1442](#1442)) ([3122bdb](3122bdb)) * **api:** connect config `email` validation ([#1454](#1454)) ([b9a1b9b](b9a1b9b)) * backport unraid/webgui[#2269](https://github.com/unraid/api/issues/2269) rc.nginx update ([#1436](#1436)) ([a7ef06e](a7ef06e)) * bigint ([e54d27a](e54d27a)) * config migration from `myservers.cfg` ([#1440](#1440)) ([c4c9984](c4c9984)) * **connect:** fatal race-condition in websocket disposal ([#1462](#1462)) ([0ec0de9](0ec0de9)) * **connect:** mothership connection ([#1464](#1464)) ([7be8bc8](7be8bc8)) * console hidden ([9b85e00](9b85e00)) * debounce is too long ([#1426](#1426)) ([f12d231](f12d231)) * delete legacy connect keys and ensure description ([22fe91c](22fe91c)) * **deps:** pin dependencies ([#1465](#1465)) ([ba75a40](ba75a40)) * **deps:** pin dependencies ([#1470](#1470)) ([412b329](412b329)) * **deps:** storybook v9 ([#1476](#1476)) ([45bb49b](45bb49b)) * **deps:** update all non-major dependencies ([#1366](#1366)) ([291ee47](291ee47)) * **deps:** update all non-major dependencies ([#1379](#1379)) ([8f70326](8f70326)) * **deps:** update all non-major dependencies ([#1389](#1389)) ([cb43f95](cb43f95)) * **deps:** update all non-major dependencies ([#1399](#1399)) ([68df344](68df344)) * **deps:** update dependency @types/diff to v8 ([#1393](#1393)) ([00da27d](00da27d)) * **deps:** update dependency cache-manager to v7 ([#1413](#1413)) ([9492c2a](9492c2a)) * **deps:** update dependency commander to v14 ([#1394](#1394)) ([106ea09](106ea09)) * **deps:** update dependency diff to v8 ([#1386](#1386)) ([e580f64](e580f64)) * **deps:** update dependency dotenv to v17 ([#1474](#1474)) ([d613bfa](d613bfa)) * **deps:** update dependency lucide-vue-next to ^0.509.0 ([#1383](#1383)) ([469333a](469333a)) * **deps:** update dependency marked to v16 ([#1444](#1444)) ([453a5b2](453a5b2)) * **deps:** update dependency shadcn-vue to v2 ([#1302](#1302)) ([26ecf77](26ecf77)) * **deps:** update dependency vue-sonner to v2 ([#1401](#1401)) ([53ca414](53ca414)) * disable file changes on Unraid 7.2 ([#1382](#1382)) ([02de89d](02de89d)) * do not start API with doinst.sh ([7d88b33](7d88b33)) * do not uninstall fully on 7.2 ([#1484](#1484)) ([2263881](2263881)) * drop console with terser ([a87d455](a87d455)) * error logs from `cloud` query when connect is not installed ([#1450](#1450)) ([719f460](719f460)) * flash backup integration with Unraid Connect config ([#1448](#1448)) ([038c582](038c582)) * header padding regression ([#1477](#1477)) ([e791cc6](e791cc6)) * incorrect state merging in redux store ([#1437](#1437)) ([17b7428](17b7428)) * lanip copy button not present ([#1459](#1459)) ([a280786](a280786)) * move to bigint scalar ([b625227](b625227)) * node_modules dir removed on plugin update ([#1406](#1406)) ([7b005cb](7b005cb)) * omit Connect actions in UPC when plugin is not installed ([#1417](#1417)) ([8c8a527](8c8a527)) * parsing of `ssoEnabled` in state.php ([#1455](#1455)) ([f542c8e](f542c8e)) * pin ranges ([#1460](#1460)) ([f88400e](f88400e)) * pr plugin promotion workflow ([#1456](#1456)) ([13bd9bb](13bd9bb)) * proper fallback if missing paths config modules ([7067e9e](7067e9e)) * rc.unraid-api now cleans up older dependencies ([#1404](#1404)) ([83076bb](83076bb)) * remote access lifecycle during boot & shutdown ([#1422](#1422)) ([7bc583b](7bc583b)) * sign out correctly on error ([#1452](#1452)) ([d08fc94](d08fc94)) * simplify usb listing ([#1402](#1402)) ([5355115](5355115)) * theme issues when sent from graph ([#1424](#1424)) ([75ad838](75ad838)) * **ui:** notifications positioning regression ([#1445](#1445)) ([f73e5e0](f73e5e0)) * use some instead of every for connect detection ([9ce2fee](9ce2fee)) ### Reverts * revert package.json dependency updates from commit 711cc9a for api and packages/* ([94420e4](94420e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat: fix shading in UPC to be less severe

e73b6e2

elibosley requested review from mdatelle and zackspear as code owners June 25, 2025 19:14

zackspear approved these changes Jun 25, 2025

View reviewed changes

coderabbitai bot reviewed Jun 25, 2025

View reviewed changes

chore: fix unit tests

c404dc0

elibosley merged commit b7c2407 into main Jun 25, 2025
12 checks passed

elibosley deleted the feat/upc-shading branch June 25, 2025 19:26

github-actions bot mentioned this pull request Jun 25, 2025

chore(main): release 4.9.0 #1378

Merged

github-actions bot mentioned this pull request Oct 27, 2025

chore(main): release 4.26.0 #1744

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: fix shading in UPC to be less severe #1438

feat: fix shading in UPC to be less severe #1438

elibosley commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: fix shading in UPC to be less severe #1438

feat: fix shading in UPC to be less severe #1438

Conversation

elibosley commented Jun 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elibosley commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)