feat: docker and info resolver issues

[elibosley]

Summary by CodeRabbit

• Bug Fixes
  • The system info query now returns only the id field, with other details loaded separately.
• Chores
  • Internal service dependencies were updated for improved maintainability.

[coderabbitai]

Walkthrough

This change disables the DockerEventService in the Docker module by removing it from the providers and exports. Additionally, the info() method in the InfoResolver is simplified to return only an object with the id field, updating its return type to Promise<Partial<Info>>.

Changes

File(s)	Change Summary
api/src/unraid-api/graph/resolvers/docker/docker.module.ts	Removed DockerEventService from imports, providers, and exports in the Docker module.
api/src/unraid-api/graph/resolvers/info/info.resolver.ts	Changed info() return type to Promise<Partial<Info>> and simplified its implementation.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant InfoResolver

    Client->>InfoResolver: info()
    InfoResolver-->>Client: { id: "info" }

Loading

Possibly related PRs

• chore: move to independent docker events #1334: Disables and reverses the integration of DockerEventService in the Docker module, directly modifying the same service registration and Docker event handling.

Suggested reviewers

• pujitm
• zackspear
• mdatelle

Poem

Code lines trimmed, a service set free,
Info now simpler, as simple can be.
Docker events silenced, just for a while,
The API’s lighter, with a minimalist style.
Cheers to the changes—concise and neat,
Progress in code, always a treat!

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

api/src/unraid-api/graph/resolvers/docker/docker.module.ts (1)

11-11: Consider complete removal instead of commenting out.

Commenting out the DockerEventService suggests this is a temporary change. If this service is being permanently disabled, consider removing it entirely along with its import statement to keep the codebase clean.

#!/bin/bash
# Description: Check if DockerEventService is imported or used elsewhere in the codebase
# Expected: Find import statement and any other references to verify if it's safe to remove

# Search for DockerEventService imports and usage
rg "DockerEventService" --type typescript --type javascript -A 2 -B 2

# Also search for any files that might reference the service
fd -e ts -e js --exec grep -l "DockerEventService" {}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70c790f and d31e482.

📒 Files selected for processing (2)

• api/src/unraid-api/graph/resolvers/docker/docker.module.ts (1 hunks)
• api/src/unraid-api/graph/resolvers/info/info.resolver.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: Build Web App
• GitHub Check: Build API
• GitHub Check: Test API
• GitHub Check: Build Unraid UI Library (Webcomponent Version)
• GitHub Check: Analyze (actions)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Cloudflare Pages

🔇 Additional comments (2)

api/src/unraid-api/graph/resolvers/docker/docker.module.ts (1)

17-17: Exports array correctly updated.

The exports array properly reflects the removal of DockerEventService, maintaining consistency with the providers array.

api/src/unraid-api/graph/resolvers/info/info.resolver.ts (1)

43-47: Excellent performance optimization with lazy field resolution.

The change from eager loading all info fields to lazy loading via @ResolveField methods is a solid GraphQL optimization. This approach:

• Only fetches requested fields, improving performance
• Follows GraphQL best practices for field resolution
• Maintains backwards compatibility since the schema structure remains unchanged

The return type change to Promise<Partial<Info>> accurately reflects that only the id field is populated initially.

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1423/dynamix.unraid.net.plg