refactor!: Track runtime version numbers; use collector result format#110
Merged
refactor!: Track runtime version numbers; use collector result format#110
Conversation
Deploying runtime-compat with
|
| Latest commit: |
dc66bbb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b4241f8.runtime-compat.pages.dev |
| Branch Preview URL: | https://collector-results-format.runtime-compat.pages.dev |
ascorbic
reviewed
Apr 15, 2024
Co-authored-by: Matt Kane <m@mk.gg>
ascorbic
reviewed
Apr 15, 2024
Collaborator
|
This is a great update. I think I've found the source of the failing action. |
ascorbic
reviewed
Apr 15, 2024
Collaborator
|
The tests are failing because of the new |
ascorbic
approved these changes
Apr 15, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR performs a big update to the format of the runtime data output for two main reasons:
To track the runtime versions directly in the data, it was determined that it would be better to utilize the collector's existing report structure and report the version using the
userAgentproperty already provided by the schema. A simple, custom UA string is used:!! runtime/version. (The preceding exclamation points are to ensure that typical UA parsers do not attempt to parse the custom string and report incorrect info.)The version information is then compiled into a
__versionproperty exported by theruntime-compat-datapackage. This property is then used in the website to show the runtime versions that were tested:Notes
Because the data structure was changed, the data has been regenerated locally.
Code has been implemented to prepare for the landing of #106.
Obtaining the version number for WinterJS within the runner has proven to be difficult. Since we are not currently updating WinterJS data, I've decided to just manually modify
data.jsonto add the version number this time around.📝 Checklist