Skip to content

chore(vendor): Synchronize with mdn-bcd-collector#106

Merged
ascorbic merged 5 commits intomainfrom
sync-with-collector
Apr 15, 2024
Merged

chore(vendor): Synchronize with mdn-bcd-collector#106
ascorbic merged 5 commits intomainfrom
sync-with-collector

Conversation

@queengooborg
Copy link
Collaborator

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR synchronizes the vendor/ folder with the mdn-bcd-collector. For the convenience of this project, the collector has now added a __version property to tests.json. This synchronizes the following files:

  • tests.json (which includes the new __version property)
  • tests.ts (updated constructor to properly filter out __version)
  • types.d.ts (unrelated, but was slightly out of sync)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 28, 2024

Deploying runtime-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: a6e8f20
Status: ✅  Deploy successful!
Preview URL: https://05ca8544.runtime-compat.pages.dev
Branch Preview URL: https://sync-with-collector.runtime-compat.pages.dev

View logs

@ascorbic
Copy link
Collaborator

fwiw, we already sync tests.json automatically in the update-data workflow. Should we add the others too?

@queengooborg
Copy link
Collaborator Author

queengooborg commented Apr 15, 2024

Ah! Didn't realize that was the case!

I'd say that it might be good to automatically synchronize those files too, yes!

@ascorbic ascorbic merged commit e39ffbb into main Apr 15, 2024
@queengooborg queengooborg deleted the sync-with-collector branch April 15, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants