fix: strip script output before logged JSON#113
Merged
Conversation
7 tasks
Collaborator
|
Good catch, thanks! Do we perhaps want to have the runner script itself write the file rather than piping logging output to save a step? LGTM though! |
queengooborg
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The bcd tests now test
console.dir, which causes them to log output as part of the test. This is causing the generated JSON to break and tests to fail, because currently we just naively write the script output to a JSON file. With this PR I've added a shell script that usessedto strip anything from before a RUNTIME_DATA_START delimiter, menaing that anything printed during the test run itself is ignored.📝 Checklist