Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding testing with custom-build netcdf and HDF5 versions. #492

Closed

Conversation

edwardhartnett
Copy link
Collaborator

Part of #467

Adding testing with custom-build netcdf and HDF5 versions.

@kgerheiser
Copy link
Contributor

This will be helpful for the Intel build

@edwardhartnett edwardhartnett marked this pull request as ready for review May 4, 2021 15:46
@edwardhartnett
Copy link
Collaborator Author

@kgerheiser this works now.

Should it be left as a separate workflow? Or do you want to try merging it into the existing workflow?

(There are other versions of netcdf we may check against, as well as perhaps multiple versions of ESMF we might want to test against.)

.github/workflows/netcdf-4.7.4.yml Outdated Show resolved Hide resolved
@edwardhartnett
Copy link
Collaborator Author

@kgerheiser please approve and we can merge.

@kgerheiser
Copy link
Contributor

What do you think of putting this into the existing workflow instead of creating a new one? I am currently testing it on a branch.

@edwardhartnett
Copy link
Collaborator Author

Fine if we can.

But I would like to add testing for netcdf-c-4.8.0 as well. ;-) Can you do that at the same time?

It builds with the same version of Fortran as 4.7.4.

@kgerheiser
Copy link
Contributor

Sure, adding NetCDF 4.8.0 is easy. I'll add it as a matrix.

@kgerheiser
Copy link
Contributor

See #503

@kgerheiser kgerheiser closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants