P&R timing flow for Innovus/Tempus #858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulk29
changed the title
rahulk29
changed the title
harrisonliew
approved these changes
Apr 26, 2024
| # Assumes that the ILM was created by Innovus (or at least the file/folder structure). | ||
| # TODO: support non-Innovus hierarchical (read netlists, etc.) | ||
| verbose_append("read_ilm -cell {module} -directory {dir}".format(dir=ilm.dir, module=ilm.module)) | ||
| verbose_append("set_ilm -cell {module} -in_dir {dir}".format(dir=ilm.dir, module=ilm.module)) |
There was a problem hiding this comment.
Why is it now set_ilm followed by read_ilm below? Just curious.
There was a problem hiding this comment.
I don't know why Cadence changed it, but in 23.1, read_ilm can only be called once; it reads all ILMs declared by set_ilm.
There was a problem hiding this comment.
Ok. Can you do a version check on this change then (i.e. keep the existing code for <23.1)
| "timing.inputs.spefs": output_dict["par.outputs.spefs"], | ||
| "timing.inputs.sdf_file": output_dict["par.outputs.sdf_file"], |
There was a problem hiding this comment.
What about the case for post-P&R timing for non-hierarchical flows? Wouldn't you need to input an SDC file that's not the post_synth_sdc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the STA flow using Innovus and Tempus.
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?poetry.lockfile if you updated the requirements inpyproject.toml?e2e/if this feature depends on updated plugins?