-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P&R timing flow for Innovus/Tempus #858
Open
rahulk29
wants to merge
12
commits into
ucb-bar:master
Choose a base branch
from
rahulk29:rahulk29/par-timing-tempus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bde95eb
Fix par timing flow for innovus/tempus
rahulk29 27994d3
default to output netlist if needed
rahulk29 1042fe1
add default value
rahulk29 b17ffef
run generate properties
rahulk29 1a128ac
add update constraint mode to tempus flow
rahulk29 d00800b
pass timing inputs to timing tool
rahulk29 6b01b83
use full tree ilms
rahulk29 c9b7e9a
use full tree ilms
rahulk29 aac99ec
make physical netlist optional
rahulk29 909da59
remove extraneous call to get
rahulk29 658edab
remove use of my constraint mode
rahulk29 d5a2660
typo
rahulk29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -757,6 +757,9 @@ def set_up_timing_tool(self, timing_tool: HammerTimingTool, | |
missing_inputs = True | ||
if missing_inputs: | ||
return False | ||
timing_tool.post_synth_sdc = self.database.get_setting("timing.inputs.post_synth_sdc") | ||
timing_tool.spefs = self.database.get_setting("timing.inputs.spefs") | ||
timing_tool.def_file = self.database.get_setting("timing.inputs.def_file") | ||
|
||
self.timing_tool = timing_tool | ||
|
||
|
@@ -1165,13 +1168,14 @@ def par_output_to_timing_input(output_dict: dict) -> Optional[dict]: | |
or None if output_dict was invalid | ||
""" | ||
try: | ||
input_files = deeplist([output_dict["par.outputs.output_netlist"]]) | ||
input_files = deeplist([output_dict.get("par.outputs.output_physical_netlist", output_dict["par.outputs.output_netlist"])]) | ||
result = { | ||
"timing.inputs.input_files": input_files, | ||
"timing.inputs.input_files_meta": "append", | ||
"timing.inputs.top_module": output_dict["par.inputs.top_module"], | ||
"timing.inputs.post_synth_sdc": output_dict["par.inputs.post_synth_sdc"], | ||
"timing.inputs.spefs": output_dict["par.outputs.spefs"], | ||
"timing.inputs.sdf_file": output_dict["par.outputs.sdf_file"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about the case for post-P&R timing for non-hierarchical flows? Wouldn't you need to input an SDC file that's not the |
||
"timing.inputs.def_file": output_dict.get("par.outputs.def_file", None), | ||
"vlsi.builtins.is_complete": False | ||
} # type: Dict[str, Any] | ||
return result | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it now
set_ilm
followed byread_ilm
below? Just curious.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why Cadence changed it, but in 23.1,
read_ilm
can only be called once; it reads all ILMs declared byset_ilm
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Can you do a version check on this change then (i.e. keep the existing code for <23.1)