Add 16-core LargeBOOM config to firechip #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure this isn't building a 17-core config? I think the WithNLargeBooms composes on top of the WithNLargeBooms in FireSimLargeBoomConfig. |
* Fix Jerry's comment on accidentally mixing multiple BOOM configs
albert-magyar
force-pushed
the
16-largeboom
branch
from
eecb57d
to
c481dc2
Compare
Thanks for catching that -- fixed it. I was simplifying the mixins I have for my branches to just add one simple version, and I messed that up. I am generating AGFIs for this config before merging it as a sanity check, so that saved me a Vivado roundtrip. |
jerryz123
approved these changes
Jan 13, 2021
jerryz123
approved these changes
Jan 13, 2021
This was referenced Jan 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: new target config
Release Notes
To highlight the resource-optimizing platform configurations added to FireSim in firesim/firesim#636, a 16-core LargeBOOM configuration has been added to FireChip.