Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the ChipTop reset pin always async #703

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Make the ChipTop reset pin always async #703

merged 2 commits into from
Oct 29, 2020

Conversation

jerryz123
Copy link
Contributor

Type of change: other enhancement

Impact: rtl change

davidbiancolin
davidbiancolin reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@davidbiancolin davidbiancolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this if Colin is.

colinschmidt
colinschmidt approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit a385963 into dev Oct 29, 2020
@jerryz123 jerryz123 mentioned this pull request Dec 7, 2020
Closed
@timsnyder-siv timsnyder-siv mentioned this pull request Dec 16, 2020
Closed
@jerryz123 jerryz123 deleted the default-async-reset branch December 24, 2020 05:20
@jerryz123 jerryz123 mentioned this pull request Jan 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbiancolin davidbiancolin davidbiancolin left review comments

@colinschmidt colinschmidt colinschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryz123 @colinschmidt @davidbiancolin