Only punch realistic subset of DebugIO through chiptop | default to JTAG+Serial #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
force-pushed
the
fix-debug-ios
branch
from
c446076
to
3583462
Compare
jerryz123
commented
Aug 28, 2020
| executor: main-env | ||
| steps: | ||
| - prepare-rtl: | ||
| project-key: "rocketchip" |
There was a problem hiding this comment.
The "rocketchip" set of tests did the exact same thing as the "chipyard-rocket" set of tests, so I removed these.
jerryz123
force-pushed
the
fix-debug-ios
branch
from
935d5ad
to
20013d1
Compare
colinschmidt
requested changes
Sep 2, 2020
jerryz123
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocketchip.debug.DebugIOhas a bunch of stuff that should not be punched offchip through the IOCell generators.Only punch out the subset of signals relevant to a real chip, namely the JTAG or clockedDMI signals.
This PR also bumps various riscv toolchain components that should have been bumped earlier. The dmiRocketconfig is also added to the regressions.
Type of change: bug fix
Impact: rtl change
Release Notes