Dromajo + TraceIO Cleanup #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side Note: For FireSim to point to the right commit, this needs to be merged in with a merge commit (not with "Squash and merge") |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: riscv-boom/riscv-boom#462 firesim/firesim#556 ucb-bar/testchipip#85
Type of change: other enhancement
Impact: rtl change + other
Release Notes
This addresses the comments in the #523 and ucb-bar/testchipip#79 PRs. I moved the BOOM Dromajo documentation to a new file and also cleaned up the TraceIO to not have 1.B wires.