Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small build system improvements #1349

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Small build system improvements #1349

merged 4 commits into from
Feb 16, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Feb 16, 2023

  • Bump to SBT 1.8.2 (doesn't break anything but adds deprecation warnings)
  • Have the EICG_wrapper.v be added by the FIRRTL addResource/Path call instead of manually copied. This requires adding a new config. fragment.
  • Add a missing " to fix the make help formatting be correct
  • Added in the VLSI Makefile a .PHONY: all to satisfy the pre-commit Makefile syntax check

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez merged commit 632a7a9 into main Feb 16, 2023
@jerryz123 jerryz123 deleted the misc-improv branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants