Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Verilator to v4.224 #1205

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/defaults.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ CI_MAKE_NPROC=8
REMOTE_MAKE_NPROC=4

# verilator version
VERILATOR_VERSION=v4.034
VERILATOR_VERSION=v4.224

HOME=$GITHUB_WORKSPACE

Expand Down
3 changes: 2 additions & 1 deletion sims/verilator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,14 @@ TRACING_CFLAGS := $(if $(filter $(VERILATOR_FST_MODE),0),,-DCY_FST_TRACE)
# we initially had --noassert for performance, but several modules use
# assertions, including dramsim, so we enable --assert by default
VERILATOR_OPT_FLAGS ?= \
-O3 \
--x-assign fast \
--x-initial fast \
--output-split 10000 \
--output-split-cfuncs 100

# default flags added for external IP (cva6/NVDLA)
VERILOG_IP_VERILATOR_FLAGS := \
-O2 \
abejgonzalez marked this conversation as resolved.
Show resolved Hide resolved
--unroll-count 256 \
-Wno-PINCONNECTEMPTY \
-Wno-ASSIGNDLY \
Expand All @@ -138,6 +138,7 @@ VERILOG_IP_VERILATOR_FLAGS := \

# normal flags used for chipyard builds (that are incompatible with vlog ip aka cva6/NVDLA)
CHIPYARD_VERILATOR_FLAGS := \
-O3 \
--assert

# options dependent on whether external IP (cva6/NVDLA) or just chipyard is used
Expand Down