Add typeclasses for immutable.Seq #3620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds type class instances for `immutable.Seq`. This is based off of the implementations of the `List` and `Vector` typeclasses.
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
==========================================
- Coverage 91.08% 90.31% -0.77%
==========================================
Files 385 391 +6
Lines 8602 8869 +267
Branches 260 247 -13
==========================================
+ Hits 7835 8010 +175
- Misses 767 859 +92 |
LukaJCB
reviewed
Sep 30, 2020
| @@ -82,6 +82,7 @@ object FunctorFilter extends ScalaVersionSpecificTraverseFilterInstances { | |||
| implicit def catsTraverseFilterForOption: TraverseFilter[Option] = | |||
| cats.instances.option.catsStdTraverseFilterForOption | |||
| implicit def catsTraverseFilterForList: TraverseFilter[List] = cats.instances.list.catsStdTraverseFilterForList | |||
| implicit def catsTraverseFilterForSeq: TraverseFilter[Seq] = cats.instances.seq.catsStdTraverseFilterForSeq | |||
There was a problem hiding this comment.
I think we'll need to move this instance down since I believe dotty will have a hard time disambiguating between this and the vector and list instances.
| @@ -113,6 +113,8 @@ object Invariant extends ScalaVersionSpecificInvariantInstances with InvariantIn | |||
| cats.instances.option.catsStdInstancesForOption | |||
| implicit def catsInstancesForList: Monad[List] with Alternative[List] with CoflatMap[List] = | |||
| cats.instances.list.catsStdInstancesForList | |||
| implicit def catsInstancesForSeq: Monad[Seq] with Alternative[Seq] with CoflatMap[Seq] = | |||
| @@ -122,6 +122,7 @@ object SemigroupK extends ScalaVersionSpecificMonoidKInstances { | |||
|
|
|||
| implicit def catsMonoidKForOption: MonoidK[Option] = cats.instances.option.catsStdInstancesForOption | |||
| implicit def catsMonoidKForList: MonoidK[List] = cats.instances.list.catsStdInstancesForList | |||
| implicit def catsMonoidKForSeq: MonoidK[Seq] = cats.instances.seq.catsStdInstancesForSeq | |||
|
Thanks for the review @LukaJCB! I went ahead and lowered the priority of the |
This was referenced Oct 17, 2020
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type class instances for
immutable.Seq. This is based off of the implementations of theListandVectortypeclasses.Closes #1222