[issue-1222] Typeclass for Seq #3006

vivekragunathan · 2019-08-24T05:47:36Z

Thank you for contributing to Cats!

This is a kind reminder to run sbt prePR and commit the changed files, if any, before submitting.

kailuowang · 2019-08-26T14:34:23Z

Thanks very much! Just want to leave a note here. I skimmed through and had a couple of thoughts. I'd like to find time to take more proper look . In the meantime, would you change the target branch to master and maybe that will also trigger a CI build?

Merging from typelevel/cats:master

…t global-plugins from idea.sbt,build.sbt ...�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mLoading global plugins from /Users/vivekragunathan/.sbt/1.0/plugins�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mLoading settings for project cats-build-build from plugins.sbt ...�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mLoading project definition from /Users/vivekragunathan/Projects/github/cats/project/project�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mLoading settings for project cats-build from plugins.sbt,build.sbt ...�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mLoading project definition from /Users/vivekragunathan/Projects/github/cats/project�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mLoading settings for project cats from version.sbt,build.sbt ...�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mResolving key references (26261 settings) ...�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mSet current project to cats (in build file:/Users/vivekragunathan/Projects/github/cats/)�[0m �[0m[�[0m�[32msuccess�[0m] �[0m�[0mTotal time: 0 s, completed Aug 26, 2019 6:38:57 PM�[0m �[0m[�[0m�[32msuccess�[0m] �[0m�[0mTotal time: 0 s, completed Aug 26, 2019 6:38:57 PM�[0m �[0m[�[0m�[32msuccess�[0m] �[0m�[0mTotal time: 5 s, completed Aug 26, 2019 6:39:03 PM�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mSetting Scala version to 2.11.12 on 30 projects.�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mReapplying settings...�[0m �[0m[�[0m�[0minfo�[0m] �[0m�[0mSet current project to cats (in build file:/Users/vivekragunathan/Projects/github/cats/)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdOrderForSeq(cats.kernel.Order)cats.kernel.Order in trait cats.kernel.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.kernel.instances.AllInstances.catsKernelStdOrderForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdMonoidForSeq()cats.kernel.Monoid in trait cats.kernel.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.kernel.instances.AllInstances.catsKernelStdMonoidForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdPartialOrderForSeq(cats.kernel.PartialOrder)cats.kernel.PartialOrder in trait cats.kernel.instances.SeqInstances1 is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.kernel.instances.AllInstances.catsKernelStdPartialOrderForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdHashForSeq(cats.kernel.Hash)cats.kernel.Hash in trait cats.kernel.instances.SeqInstances1 is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.kernel.instances.AllInstances.catsKernelStdHashForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdEqForSeq(cats.kernel.Eq)cats.kernel.Eq in trait cats.kernel.instances.SeqInstances2 is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.kernel.instances.AllInstances.catsKernelStdEqForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsSyntaxSeq(scala.collection.immutable.Seq)scala.collection.immutable.Seq in trait cats.syntax.SeqSyntax is inherited by class AllSyntax in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.syntax.AllSyntax.catsSyntaxSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdOrderForSeq(cats.kernel.Order)cats.kernel.Order in trait cats.kernel.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsKernelStdOrderForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdMonoidForSeq()cats.kernel.Monoid in trait cats.kernel.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsKernelStdMonoidForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract synthetic method cats$instances$SeqInstances$_setter_$catsStdTraverseFilterForSeq_=(cats.TraverseFilter)Unit in trait cats.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.cats$instances$SeqInstances$_setter_$catsStdTraverseFilterForSeq_=")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsStdShowForSeq(cats.Show)cats.Show in trait cats.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsStdShowForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract synthetic method cats$instances$SeqInstances$_setter_$catsStdInstancesForSeq_=(cats.Traverse)Unit in trait cats.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.cats$instances$SeqInstances$_setter_$catsStdInstancesForSeq_=")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsStdInstancesForSeq()cats.Traverse in trait cats.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsStdInstancesForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsStdTraverseFilterForSeq()cats.TraverseFilter in trait cats.instances.SeqInstances is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsStdTraverseFilterForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdPartialOrderForSeq(cats.kernel.PartialOrder)cats.kernel.PartialOrder in trait cats.kernel.instances.SeqInstances1 is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsKernelStdPartialOrderForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdHashForSeq(cats.kernel.Hash)cats.kernel.Hash in trait cats.kernel.instances.SeqInstances1 is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsKernelStdHashForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m * abstract method catsKernelStdEqForSeq(cats.kernel.Eq)cats.kernel.Eq in trait cats.kernel.instances.SeqInstances2 is inherited by class AllInstances in current version.�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m filter with: ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("cats.instances.AllInstances.catsKernelStdEqForSeq")�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0mjava.lang.RuntimeException: Cats kernel: Binary compatibility check failed!�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.sys.package$.error(package.scala:26)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.SbtMima$.reportModuleErrors(SbtMima.scala:83)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$9(MimaPlugin.scala:76)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$9$adapted(MimaPlugin.scala:59)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.collection.immutable.HashMap$HashMap1.foreach(HashMap.scala:230)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:461)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$8(MimaPlugin.scala:59)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$8$adapted(MimaPlugin.scala:44)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.Function1.$anonfun$compose$1(Function1.scala:44)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:40)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.std.Transform$$anon$4.work(System.scala:67)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.Execute.$anonfun$submit$2(Execute.scala:269)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.Execute.work(Execute.scala:278)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.Execute.$anonfun$submit$1(Execute.scala:269)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.FutureTask.run(FutureTask.java:266)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.FutureTask.run(FutureTask.java:266)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.lang.Thread.run(Thread.java:748)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0mjava.lang.RuntimeException: Cats core: Binary compatibility check failed!�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.sys.package$.error(package.scala:26)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.SbtMima$.reportModuleErrors(SbtMima.scala:83)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$9(MimaPlugin.scala:76)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$9$adapted(MimaPlugin.scala:59)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.collection.immutable.HashMap$HashMap1.foreach(HashMap.scala:230)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:461)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$8(MimaPlugin.scala:59)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$mimaReportSettings$8$adapted(MimaPlugin.scala:44)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at scala.Function1.$anonfun$compose$1(Function1.scala:44)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:40)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.std.Transform$$anon$4.work(System.scala:67)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.Execute.$anonfun$submit$2(Execute.scala:269)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.Execute.work(Execute.scala:278)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.Execute.$anonfun$submit$1(Execute.scala:269)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.FutureTask.run(FutureTask.java:266)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.FutureTask.run(FutureTask.java:266)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m at java.lang.Thread.run(Thread.java:748)�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m(kernelJVM / �[31mmimaReportBinaryIssues�[0m) Cats kernel: Binary compatibility check failed!�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0m(coreJVM / �[31mmimaReportBinaryIssues�[0m) Cats core: Binary compatibility check failed!�[0m �[0m[�[0m�[31merror�[0m] �[0m�[0mTotal time: 14 s, completed Aug 26, 2019 6:39:20 PM�[0m to scalafmt :(

codecov-io · 2019-08-30T18:50:12Z

Codecov Report

Merging #3006 into master will decrease coverage by 0.08%.
The diff coverage is 87.75%.

@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
- Coverage   93.56%   93.48%   -0.09%     
==========================================
  Files         368      371       +3     
  Lines        6949     7047      +98     
  Branches      195      184      -11     
==========================================
+ Hits         6502     6588      +86     
- Misses        447      459      +12

Impacted Files	Coverage Δ
core/src/main/scala/cats/syntax/seq.scala	`100% <100%> (ø)`
...ain/scala/cats/kernel/instances/SeqInstances.scala	`66.66% <66.66%> (ø)`
core/src/main/scala/cats/instances/seq.scala	`94.11% <94.11%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721041...2cad8f3. Read the comment docs.

larsrh · 2020-10-20T15:20:52Z

Implemented by #3620.

Vivek Ragunathan added 2 commits August 23, 2019 22:24

issue-1222: typeclass for seq

52a723c

issue-1222: typeclass for seq

66995ad

vivekragunathan changed the base branch from 1.6.x to 2.0.x August 24, 2019 05:48

vivekragunathan changed the base branch from 2.0.x to master August 26, 2019 17:34

vivekragunathan and others added 4 commits August 26, 2019 10:41

Merge pull request #1 from typelevel/master

bb891f6

Merging from typelevel/cats:master

Merge branch 'master' into feature/issue-1222/typeclass_for_seq

111976a

Fixed the bin compat errors

2cad8f3

larsrh closed this Oct 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[issue-1222] Typeclass for Seq #3006

[issue-1222] Typeclass for Seq #3006

Uh oh!

vivekragunathan commented Aug 24, 2019

Uh oh!

kailuowang commented Aug 26, 2019

Uh oh!

codecov-io commented Aug 30, 2019

Uh oh!

larsrh commented Oct 20, 2020

Uh oh!

Uh oh!

Uh oh!

[issue-1222] Typeclass for Seq #3006

[issue-1222] Typeclass for Seq #3006

Uh oh!

Conversation

vivekragunathan commented Aug 24, 2019

Uh oh!

kailuowang commented Aug 26, 2019

Uh oh!

codecov-io commented Aug 30, 2019

Codecov Report

Uh oh!

larsrh commented Oct 20, 2020

Uh oh!

Uh oh!