Port tests to Dotty (the 2nd) #3636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #3636 +/- ##
==========================================
- Coverage 90.28% 90.24% -0.05%
==========================================
Files 391 391
Lines 8872 8855 -17
Branches 251 256 +5
==========================================
- Hits 8010 7991 -19
- Misses 862 864 +2 |
LukaJCB
approved these changes
Oct 17, 2020
satorg
reviewed
Oct 12, 2022
Comment on lines
+29
to
+36
| test("hygiene") { | ||
| trait FunctionK | ||
| def optionToList[A](option: Option[A]): List[A] = option.toList | ||
| val fOptionToList = cats.arrow.FunctionK.lift(optionToList _) | ||
| forAll { (a: Option[Int]) => | ||
| assert(fOptionToList(a) === (optionToList(a))) | ||
| } | ||
| } |
There was a problem hiding this comment.
@larsrh this trait FunctionK is not used here. I wonder is it left there intentionally or just an oversight? Could you clarify if you have time please? I wonder if I can simply remove this trait out or I should try to keep it but mark it as "unused" to suppress an "unused" compiler warning about this trait.
There was a problem hiding this comment.
That's on purpose, since it is a hygiene test. We're checking whether the macro uses the correct FunctionK trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3552.
Lots of the ground work done by @LukaJCB. I just added a few commits.
@smarter writes:
I still think we should get this in sooner than later, because other development in
mastermay easily break this again (see e.g. a449e16 which was caused by #3620).