Skip to content

Conversation

@hyanwong
Copy link
Member

For some reason this didn't auto-install for me using setup.py. Not sure why it works in the CI testing suite, but it can't harm to add it to the dev requirements, surely.

@jeromekelleher
Copy link
Member

For some reason this didn't auto-install for me using setup.py. Not sure why it works in the CI testing suite, but it can't harm to add it to the dev requirements, surely.

Setup.py only includes deps needed for installation, not for testing. Good to add Biopython to the development requirements all right though, thanks.

@hyanwong
Copy link
Member Author

Ah - that explains it. Thanks for clarifying.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #268 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage    85.8%   85.64%   -0.17%     
==========================================
  Files          19       19              
  Lines       14068    13735     -333     
  Branches     2736     2665      -71     
==========================================
- Hits        12071    11763     -308     
+ Misses       1043     1022      -21     
+ Partials      954      950       -4
Flag Coverage Δ
#c_tests 86.56% <ø> (-0.16%) ⬇️
#python_c_tests 89.9% <ø> (-0.04%) ⬇️
#python_tests 99.16% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
c/tskit/trees.c 90.38% <0%> (-0.2%) ⬇️
c/tskit/core.c 82.47% <0%> (-0.14%) ⬇️
python/_tskitmodule.c 83.22% <0%> (-0.14%) ⬇️
python/tskit/trees.py 98.57% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f24d6a...2c28dbb. Read the comment docs.

@jeromekelleher
Copy link
Member

Looks good - I rebased to bring it up to date. Will merge once CI goes through.

PyVCF
python_jsonschema_objects
biopython
Bio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't BioPython, it's a different package; change to 'biopython'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

biopython is already in development.txt. So not sure why this didn't work before for me. But I guess this PR can simply be cancelled

@hyanwong
Copy link
Member Author

Was the wrong module anyway

@hyanwong hyanwong closed this Jul 27, 2019
@hyanwong hyanwong deleted the add-bio-module-req branch September 24, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants