-
Notifications
You must be signed in to change notification settings - Fork 79
Add the Bio module for test_parsimony #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Setup.py only includes deps needed for installation, not for testing. Good to add Biopython to the development requirements all right though, thanks. |
|
Ah - that explains it. Thanks for clarifying. |
ad8042d to
2c28dbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 85.8% 85.64% -0.17%
==========================================
Files 19 19
Lines 14068 13735 -333
Branches 2736 2665 -71
==========================================
- Hits 12071 11763 -308
+ Misses 1043 1022 -21
+ Partials 954 950 -4
Continue to review full report at Codecov.
|
|
Looks good - I rebased to bring it up to date. Will merge once CI goes through. |
| PyVCF | ||
| python_jsonschema_objects | ||
| biopython | ||
| Bio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't BioPython, it's a different package; change to 'biopython'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
biopython is already in development.txt. So not sure why this didn't work before for me. But I guess this PR can simply be cancelled
|
Was the wrong module anyway |
For some reason this didn't auto-install for me using
setup.py. Not sure why it works in the CI testing suite, but it can't harm to add it to the dev requirements, surely.