Skip to content

Conversation

@hyanwong
Copy link
Member

At the moment tskit.NULL comes because we do from _tskit import NULL within trees.py, then in __init.py__ we do from tskit.trees import *. This indirect import seems nasty to me. So I've changed this so that all constants are explicitly exported via a line in __init.py__ instead.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #267 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #267      +/-   ##
=========================================
+ Coverage    85.8%   85.8%   +<.01%     
=========================================
  Files          19      19              
  Lines       14068   14071       +3     
  Branches     2736    2736              
=========================================
+ Hits        12071   12074       +3     
  Misses       1043    1043              
  Partials      954     954
Flag Coverage Δ
#c_tests 86.73% <100%> (ø) ⬆️
#python_c_tests 89.94% <100%> (ø) ⬆️
#python_tests 99.17% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/trees.py 98.58% <100%> (ø) ⬆️
python/tskit/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f24d6a...03e43df. Read the comment docs.

@jeromekelleher
Copy link
Member

LGTM, thanks. will merge after #268.

@jeromekelleher jeromekelleher merged commit 34cdc0f into tskit-dev:master Jul 26, 2019
@hyanwong hyanwong deleted the add-missing-constant branch September 24, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants