Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracked_samples to natively use numpy array. #64

Open
jeromekelleher opened this issue Feb 2, 2018 · 1 comment
Open

Update tracked_samples to natively use numpy array. #64

jeromekelleher opened this issue Feb 2, 2018 · 1 comment
Labels
Performance This issue addresses performance, either runtime or memory Python API Issue is about the Python API
Milestone
Python upcoming

Comments

@jeromekelleher
Copy link
Member

#391 changed the TreeSequence.samples method to return a numpy array. Change the .trees() method to use a numpy array without first changing to a python list. Needs an update to the low level C API.
@jeromekelleher jeromekelleher self-assigned this Feb 2, 2018
@jeromekelleher jeromekelleher transferred this issue from tskit-dev/msprime Jan 11, 2019
@jeromekelleher jeromekelleher mentioned this issue May 28, 2019
Closed
@jeromekelleher jeromekelleher changed the title Update tracked_leaves to natively use numpy array. Update tracked_samples to natively use numpy array. Feb 10, 2020
@jeromekelleher jeromekelleher added this to the Python 0.2.4 milestone Feb 12, 2020
@jeromekelleher
Copy link
Member Author

Also remove the conversion to list() in the Python code.

@jeromekelleher jeromekelleher added Performance This issue addresses performance, either runtime or memory Python API Issue is about the Python API labels Sep 29, 2020
@jeromekelleher jeromekelleher removed their assignment Nov 13, 2020
@benjeffery benjeffery modified the milestones: Python 0.3.3, Python 0.3.4 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance This issue addresses performance, either runtime or memory Python API Issue is about the Python API
Projects
None yet
Milestone
Python upcoming
Development

No branches or pull requests
2 participants
@benjeffery @jeromekelleher