@uppy/svelte: use SvelteKit as the build tool #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (319 commits) build(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (#5483) Release: uppy@4.4.1 (#5479) @uppy/transloadit: fix multiple upload batches & run again (#5478) build(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (#5477) build(deps): bump vite from 5.2.11 to 5.4.8 (#5471) build(deps-dev): bump rollup from 4.18.0 to 4.22.4 (#5470) build(deps): bump vite from 5.2.11 to 5.4.6 (#5466) Release: uppy@4.4.0 (#5467) @uppy/tus: fix retry check for status code 400 (#5461) meta: fix AwsS3 endpoint option in private/dev build(deps): bump body-parser from 1.20.2 to 1.20.3 (#5462) build(deps-dev): bump vite from 5.3.1 to 5.3.6 (#5459) @uppy/tus: set response from tus-js-client (#5456) docs: fix assemblyOptions example for React (#5450) docs: rename Edgly to Smart CDN (#5449) @uppy/tus: correctly type tus on UppyFile (#5454) docs: remove old legacy CDN reference @uppy/xhr-upload: pass files to onBeforeRequest (#5447) @uppy/svelte: fix generated module to not bundle Svelte (#5446) Bump svelte from 4.2.18 to 4.2.19 (#5440) ...
* main: Fix redis emitter (#5474)
This comment was marked as resolved.
This comment was marked as resolved.
Diff output filesNo diff |
Murderlon
added a commit
that referenced
this pull request
Oct 15, 2024
* main: (65 commits) `.handleInputChange()` - use `.currentTarget`; clear the input using `''` (#5381) build(deps): bump @blakeembrey/template from 1.1.0 to 1.2.0 (#5448) Update packages/@uppy/locales/src/fr_FR.ts (#5472) @uppy/svelte: use SvelteKit as the build tool (#5484) @uppy/xhr-upload: add response to upload-error callback (#5486) tus: Avoid duplicate `upload-error` event (#5485) Fix redis emitter (#5474) build(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (#5483) Release: uppy@4.4.1 (#5479) @uppy/transloadit: fix multiple upload batches & run again (#5478) build(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (#5477) build(deps): bump vite from 5.2.11 to 5.4.8 (#5471) build(deps-dev): bump rollup from 4.18.0 to 4.22.4 (#5470) build(deps): bump vite from 5.2.11 to 5.4.6 (#5466) Release: uppy@4.4.0 (#5467) @uppy/tus: fix retry check for status code 400 (#5461) meta: fix AwsS3 endpoint option in private/dev build(deps): bump body-parser from 1.20.2 to 1.20.3 (#5462) build(deps-dev): bump vite from 5.3.1 to 5.3.6 (#5459) @uppy/tus: set response from tus-js-client (#5456) ...
Merged
github-actions bot
added a commit
that referenced
this pull request
Oct 15, 2024
| Package | Version | Package | Version | | ---------------- | ------- | ---------------- | ------- | | @uppy/companion | 5.1.2 | @uppy/svelte | 4.1.0 | | @uppy/core | 4.2.2 | @uppy/tus | 4.1.2 | | @uppy/dashboard | 4.1.1 | @uppy/utils | 6.0.3 | | @uppy/drag-drop | 4.0.3 | @uppy/xhr-upload | 4.2.1 | | @uppy/file-input | 4.0.2 | uppy | 4.5.0 | | @uppy/locales | 4.2.0 | | | - @uppy/dashboard: Dashboard - convert some files to typescript (Evgenia Karunus / #5367) - @uppy/dashboard,@uppy/drag-drop,@uppy/file-input: `.handleInputChange()` - use `.currentTarget`; clear the input using `''` (Evgenia Karunus / #5381) - meta: build(deps): bump @blakeembrey/template from 1.1.0 to 1.2.0 (dependabot[bot] / #5448) - @uppy/locales: Update packages/@uppy/locales/src/fr_FR.ts (Zéfyx / #5472) - @uppy/svelte: use SvelteKit as the build tool (Merlijn Vos / #5484) - @uppy/xhr-upload: add response to upload-error callback (Caleb Hardin / #5486) - @uppy/tus: tus: Avoid duplicate `upload-error` event (Marius / #5485) - @uppy/companion: Fix redis emitter (Mikael Finstad / #5474) - meta: build(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (dependabot[bot] / #5483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5475
Instead of a custom rollup script, which used outdated and deprecated dependencies, I migrated to SvelteKit so we don't have to worry about maintaining a build script to work between Svelte 4.x and 5.x. It now just works, tested in both SveleKit with Svelte 4.x and a regular Svelte 5.x app.
If you are packaging a library, SvelteKit expects it to be in
src/lib/so I created this nested folder (resulting in a big diff).I also solved some HTML warnings from SvelteKit.