@uppy/tus: fix retry check for status code 400 #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesdiff --git a/packages/@uppy/tus/lib/index.js b/packages/@uppy/tus/lib/index.js
index c39418d..abeb91e 100644
--- a/packages/@uppy/tus/lib/index.js
+++ b/packages/@uppy/tus/lib/index.js
@@ -264,7 +264,7 @@ function _uploadLocalFile2(file) {
}
this.requests.rateLimit(next.value);
}
- } else if (status != null && status > 400 && status < 500 && status !== 409 && status !== 423) {
+ } else if (status != null && status >= 400 && status < 500 && status !== 409 && status !== 423) {
return false;
} else if (typeof navigator !== "undefined" && navigator.onLine === false) {
if (!this.requests.isPaused) { |
Merged
github-actions bot
added a commit
that referenced
this pull request
Sep 20, 2024
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/companion | 5.1.1 | @uppy/tus | 4.1.1 | | @uppy/svelte | 4.0.2 | @uppy/xhr-upload | 4.2.0 | | @uppy/transloadit | 4.1.1 | uppy | 4.4.0 | - @uppy/tus: fix retry check for status code 400 (Merlijn Vos / #5461) - meta: Merge branch 'main' of https://github.com/transloadit/uppy (Murderlon) - meta: fix AwsS3 endpoint option in private/dev (Murderlon) - examples: build(deps): bump body-parser from 1.20.2 to 1.20.3 (dependabot[bot] / #5462) - examples: build(deps-dev): bump vite from 5.3.1 to 5.3.6 (dependabot[bot] / #5459) - @uppy/tus: set response from tus-js-client (Merlijn Vos / #5456) - docs: fix assemblyOptions example for React (Merlijn Vos / #5450) - docs: rename Edgly to Smart CDN (Merlijn Vos / #5449) - @uppy/tus: correctly type tus on UppyFile (Merlijn Vos / #5454) - docs: remove old legacy CDN reference (Murderlon) - @uppy/xhr-upload: pass files to onBeforeRequest (Merlijn Vos / #5447) - @uppy/svelte: fix generated module to not bundle Svelte (Antoine du Hamel / #5446) - examples,@uppy/svelte: Bump svelte from 4.2.18 to 4.2.19 (dependabot[bot] / #5440) - meta: bump Yarn to 4.4.1 (Antoine du Hamel / #5445) - docs: fix broken links in locale docs (Serghei Cebotari / #5441)
Murderlon
added a commit
that referenced
this pull request
Oct 7, 2024
* main: (319 commits) build(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (#5483) Release: uppy@4.4.1 (#5479) @uppy/transloadit: fix multiple upload batches & run again (#5478) build(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (#5477) build(deps): bump vite from 5.2.11 to 5.4.8 (#5471) build(deps-dev): bump rollup from 4.18.0 to 4.22.4 (#5470) build(deps): bump vite from 5.2.11 to 5.4.6 (#5466) Release: uppy@4.4.0 (#5467) @uppy/tus: fix retry check for status code 400 (#5461) meta: fix AwsS3 endpoint option in private/dev build(deps): bump body-parser from 1.20.2 to 1.20.3 (#5462) build(deps-dev): bump vite from 5.3.1 to 5.3.6 (#5459) @uppy/tus: set response from tus-js-client (#5456) docs: fix assemblyOptions example for React (#5450) docs: rename Edgly to Smart CDN (#5449) @uppy/tus: correctly type tus on UppyFile (#5454) docs: remove old legacy CDN reference @uppy/xhr-upload: pass files to onBeforeRequest (#5447) @uppy/svelte: fix generated module to not bundle Svelte (#5446) Bump svelte from 4.2.18 to 4.2.19 (#5440) ...
Murderlon
added a commit
that referenced
this pull request
Oct 15, 2024
* main: (65 commits) `.handleInputChange()` - use `.currentTarget`; clear the input using `''` (#5381) build(deps): bump @blakeembrey/template from 1.1.0 to 1.2.0 (#5448) Update packages/@uppy/locales/src/fr_FR.ts (#5472) @uppy/svelte: use SvelteKit as the build tool (#5484) @uppy/xhr-upload: add response to upload-error callback (#5486) tus: Avoid duplicate `upload-error` event (#5485) Fix redis emitter (#5474) build(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (#5483) Release: uppy@4.4.1 (#5479) @uppy/transloadit: fix multiple upload batches & run again (#5478) build(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (#5477) build(deps): bump vite from 5.2.11 to 5.4.8 (#5471) build(deps-dev): bump rollup from 4.18.0 to 4.22.4 (#5470) build(deps): bump vite from 5.2.11 to 5.4.6 (#5466) Release: uppy@4.4.0 (#5467) @uppy/tus: fix retry check for status code 400 (#5461) meta: fix AwsS3 endpoint option in private/dev build(deps): bump body-parser from 1.20.2 to 1.20.3 (#5462) build(deps-dev): bump vite from 5.3.1 to 5.3.6 (#5459) @uppy/tus: set response from tus-js-client (#5456) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5460