Correctly report indices and aliases #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthon
force-pushed
the
bugfix-indexes-and-aliases-inaccurate
branch
2 times, most recently
from
6c2879e
to
79dce04
Compare
rabotyaga
suggested changes
Feb 11, 2021
|
@rabotyaga as you guessed correctly it breaks... let me check if I can quickly solve this, otherwise I think it might be good to close this PR |
dalthon
force-pushed
the
bugfix-indexes-and-aliases-inaccurate
branch
from
79dce04
to
7edd7ae
Compare
|
@rabotyaga unfortunately we have to rely on something other than name prefix to associate Index class and indexes. This may be done by aliases or perfect name match. Not every cases are covered, at chewy/spec/chewy/index/actions_spec.rb Line 64 in 7edd7ae chewy/spec/chewy/index/actions_spec.rb Line 123 in 7edd7ae But I believe that is better to have false positives than false negatives in that unlikely case. WDYT? |
dalthon
force-pushed
the
bugfix-indexes-and-aliases-inaccurate
branch
from
9b1ca67
to
bca1101
Compare
Improve the reporting on indices and aliases that match index naming.
rabotyaga
force-pushed
the
bugfix-indexes-and-aliases-inaccurate
branch
from
bca1101
to
a815a2d
Compare
rabotyaga
approved these changes
Feb 12, 2021
added 2 commits
February 13, 2021 09:22
rabotyaga
force-pushed
the
bugfix-indexes-and-aliases-inaccurate
branch
from
7b539fe
to
2fd5489
Compare
barthez
approved these changes
Feb 15, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
* Correctly report indices and aliases * Fix rubocop offense * Fix specs & Changelog * Add `include_type_name` parameter for ES 6.7-6.8 for `client.indices.get` request Co-authored-by: mpeychich <mpeychich@mac.com> Co-authored-by: Ivan Rabotyaga <ivan.rabotyaga@toptal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a rebased version of #689