Correctly report indices and aliases (#757)

* Correctly report indices and aliases
* Fix rubocop offense
* Fix specs & Changelog
* Add `include_type_name` parameter for ES 6.7-6.8 for `client.indices.get` request

Co-authored-by: mpeychich <mpeychich@mac.com>
Co-authored-by: Ivan Rabotyaga <ivan.rabotyaga@toptal.com>

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 ### Changes
 
+  * [#757](https://github.com/toptal/chewy/pull/757): **(Breaking)** Fix `Chewy::Index.index` & `Chewy::Index.aliases` to correctly report indexes and aliases ([@mpeychich][], [@dalthon][])
   * [#761](https://github.com/toptal/chewy/pull/761): Avoid fetching scope data to check if it is blank ([@dalthon][])
 
 ### Bugs Fixed

lib/chewy/index/actions.rb

@@ -182,7 +182,7 @@ def #{method}(*args)
         def reset!(suffix = nil, apply_journal: true, journal: false, **import_options)
           result = if suffix.present?
             start_time = Time.now
-            indexes = self.indexes
+            indexes = self.indexes - [index_name]
             create! suffix, alias: false
 
             general_name = index_name

lib/chewy/index/aliases.rb

@@ -5,14 +5,25 @@ module Aliases
 
       module ClassMethods
         def indexes
-          client.indices.get_alias(name: index_name).keys
-        rescue Elasticsearch::Transport::Transport::Errors::NotFound
-          []
+          get_args = {index: index_name}
+          get_args[:include_type_name] = true if Runtime.version >= '6.7.0'
+          indexes = empty_if_not_found { client.indices.get(**get_args).keys }
+          indexes += empty_if_not_found { client.indices.get_alias(name: index_name).keys }
+          indexes.compact.uniq
         end
 
         def aliases
-          name = index_name
-          client.indices.get_alias(index: name, name: '*')[name].try(:[], 'aliases').try(:keys) || []
+          empty_if_not_found do
+            client.indices.get_alias(index: index_name, name: '*').values.flat_map do |aliases|
+              aliases['aliases'].keys
+            end
+          end.compact.uniq
+        end
+
+      private
+
+        def empty_if_not_found
+          yield
         rescue Elasticsearch::Transport::Transport::Errors::NotFound
           []
         end