Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly report indices and aliases #689

Conversation

mpeychich
Copy link
Contributor

Improve the reporting on indices and aliases that match index naming.

Before

Indices created via Chewy without a suffix would fail to report themselves as an index or alias for the Chewy index.

DummyIndex.create! # => {'acknowledged' => true}
DummyIndex.indexes # => []
DummyIndex.aliases # => []

Indices created via Chewy with a suffix would correctly report the suffixed index but would fail to report the alias

DummyIndex.create!('2013') # => {'acknowledged' => true}
DummyIndex.indexes # => ['dummies_2013']
DummyIndex.aliases # => []

After

Indices created via Chewy without a suffix will correctly report themselves as an index.

DummyIndex.create!
DummyIndex.indexes # => ['dummies']
DummyIndex.aliases # => []

Indices created via Chewy with a suffix will correctly report the alias

DummyIndex.create!('2013') # => {'acknowledged' => true}
DummyIndex.indexes # => ['dummies_2013']
DummyIndex.aliases # => ['dummies']

Improve the reporting on indices and aliases that match index naming.
@dalthon
Copy link
Contributor

dalthon commented Feb 12, 2021

It was rebased at #757 and some details were changed in order to avoid some false positives on indexes when two distinct classes are named with containing names.

It is waiting a little to merge, just to make sure that breaking changes introduced will not affect other stuff

@dalthon dalthon closed this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants