fix(platform): add needUpdate func in cluster/machine provider #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoryu
reviewed
Aug 23, 2021
leoryu
reviewed
Aug 23, 2021
leoryu
reviewed
Aug 23, 2021
pavlelee
reviewed
Aug 23, 2021
|
|
||
| provider, _ := clusterprovider.GetProvider(cluster.Spec.Type) | ||
| if provider == nil { | ||
| c.log.Infof("get cluster provider with %s failed", cluster.Spec.Type) |
Collaborator
There was a problem hiding this comment.
pavlelee
reviewed
Aug 23, 2021
|
|
||
| provider, _ := machineprovider.GetProvider(machine.Spec.Type) | ||
| if provider == nil { | ||
| c.log.Infof("get machine provider with %s failed", machine.Spec.Type) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
User can define customized
needUpdatefunction in provider, default reture false.Which issue(s) this PR fixes:
Fixes #1484