fix(platform): add needUpdate func in cluster/machine provider

Author: Cui Shuaijie

pkg/platform/controller/cluster/cluster_controller.go

@@ -34,6 +34,7 @@ import (
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/util/workqueue"
+
 	platformversionedclient "tkestack.io/tke/api/client/clientset/versioned/typed/platform/v1"
 	platformv1informer "tkestack.io/tke/api/client/informers/externalversions/platform/v1"
 	platformv1lister "tkestack.io/tke/api/client/listers/platform/v1"
@@ -131,9 +132,18 @@ func (c *Controller) addCluster(obj interface{}) {
 func (c *Controller) updateCluster(old, obj interface{}) {
 	oldCluster := old.(*platformv1.Cluster)
 	cluster := obj.(*platformv1.Cluster)
-	if !c.needsUpdate(oldCluster, cluster) {
-		return
+	provider, err := clusterprovider.GetProvider(cluster.Spec.Type)
+	if err != nil || provider == nil {
+		c.log.Error(err, "checking cluster needUpdate", "provider ", provider)
+		if !c.needsUpdate(oldCluster, cluster) {
+			return
+		}
+	} else {
+		if !c.needsUpdate(oldCluster, cluster) && !provider.NeedUpdate(oldCluster, cluster) {
+			return
+		}
 	}
+
 	c.log.Info("Updating cluster", "clusterName", cluster.Name)
 	c.enqueue(cluster)
 }

pkg/platform/controller/machine/machine_controller.go

@@ -109,9 +109,19 @@ func (c *Controller) addMachine(obj interface{}) {
 func (c *Controller) updateMachine(old, obj interface{}) {
 	oldMachine := old.(*platformv1.Machine)
 	machine := obj.(*platformv1.Machine)
-	if !c.needsUpdate(oldMachine, machine) {
-		return
+
+	provider, err := machineprovider.GetProvider(machine.Spec.Type)
+	if err != nil || provider == nil {
+		c.log.Error(err, "checking machine needUpdate", "provider ", provider)
+		if !c.needsUpdate(oldMachine, machine) {
+			return
+		}
+	} else {
+		if !c.needsUpdate(oldMachine, machine) && !provider.NeedUpdate(oldMachine, machine) {
+			return
+		}
 	}
+
 	c.log.Info("Updating machine", "machine", machine.Name)
 	c.enqueue(machine)
 }

pkg/platform/provider/cluster/interface.go

@@ -90,6 +90,9 @@ type CredentialProvider interface {
 type Provider interface {
 	Name() string
 
+	// NeedUpdate could be implemented by user to judge whether cluster need update or not.
+	NeedUpdate(old, new *platformv1.Cluster) bool
+
 	APIProvider
 	ControllerProvider
 	CredentialProvider
@@ -339,6 +342,10 @@ func (p *DelegateProvider) OnFilter(ctx context.Context, cluster *platformv1.Clu
 	return true
 }
 
+func (p *DelegateProvider) NeedUpdate(old, new *platformv1.Cluster) bool {
+	return false
+}
+
 func (p *DelegateProvider) getNextConditionType(conditionType string, handlers []Handler) string {
 	var (
 		i       int

pkg/platform/provider/machine/interface.go

@@ -59,6 +59,9 @@ type Provider interface {
 	OnCreate(ctx context.Context, machine *platformv1.Machine, cluster *typesv1.Cluster) error
 	OnUpdate(ctx context.Context, machine *platformv1.Machine, cluster *typesv1.Cluster) error
 	OnDelete(ctx context.Context, machine *platformv1.Machine, cluster *typesv1.Cluster) error
+
+	// NeedUpdate could be implemented by user to judge whether machine need update or not.
+	NeedUpdate(old, new *platformv1.Machine) bool
 }
 
 var _ Provider = &DelegateProvider{}
@@ -213,6 +216,10 @@ func (p *DelegateProvider) OnDelete(ctx context.Context, machine *platformv1.Mac
 	return nil
 }
 
+func (p *DelegateProvider) NeedUpdate(old, new *platformv1.Machine) bool {
+	return false
+}
+
 func (p *DelegateProvider) getNextConditionType(conditionType string) string {
 	var (
 		i       int