fix(platform): add needUpdate func in cluster/machine provider (#1503)

Co-authored-by: Cui Shuaijie <arescui@tencent.com>

Author: TomatoAres

pkg/platform/controller/cluster/cluster_controller.go

@@ -34,6 +34,7 @@ import (
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/util/workqueue"
+
 	platformversionedclient "tkestack.io/tke/api/client/clientset/versioned/typed/platform/v1"
 	platformv1informer "tkestack.io/tke/api/client/informers/externalversions/platform/v1"
 	platformv1lister "tkestack.io/tke/api/client/listers/platform/v1"
@@ -131,7 +132,14 @@ func (c *Controller) addCluster(obj interface{}) {
 func (c *Controller) updateCluster(old, obj interface{}) {
 	oldCluster := old.(*platformv1.Cluster)
 	cluster := obj.(*platformv1.Cluster)
-	if !c.needsUpdate(oldCluster, cluster) {
+
+	controllerNeedUpddateResult := c.needsUpdate(oldCluster, cluster)
+	var providerNeedUpddateResult bool
+	provider, _ := clusterprovider.GetProvider(cluster.Spec.Type)
+	if provider != nil {
+		providerNeedUpddateResult = provider.NeedUpdate(oldCluster, cluster)
+	}
+	if !(controllerNeedUpddateResult || providerNeedUpddateResult) {
 		return
 	}
 	c.log.Info("Updating cluster", "clusterName", cluster.Name)

pkg/platform/controller/machine/machine_controller.go

@@ -109,7 +109,14 @@ func (c *Controller) addMachine(obj interface{}) {
 func (c *Controller) updateMachine(old, obj interface{}) {
 	oldMachine := old.(*platformv1.Machine)
 	machine := obj.(*platformv1.Machine)
-	if !c.needsUpdate(oldMachine, machine) {
+
+	controllerNeedUpddateResult := c.needsUpdate(oldMachine, machine)
+	var providerNeedUpddateResult bool
+	provider, _ := machineprovider.GetProvider(machine.Spec.Type)
+	if provider != nil {
+		providerNeedUpddateResult = provider.NeedUpdate(oldMachine, machine)
+	}
+	if !(controllerNeedUpddateResult || providerNeedUpddateResult) {
 		return
 	}
 	c.log.Info("Updating machine", "machine", machine.Name)

pkg/platform/provider/cluster/interface.go

@@ -65,6 +65,8 @@ type ControllerProvider interface {
 	Setup() error
 	// Teardown called by controller for plugin do some clean job.
 	Teardown() error
+	// NeedUpdate could be implemented by user to judge whether cluster need update or not.
+	NeedUpdate(old, new *platformv1.Cluster) bool
 
 	OnCreate(ctx context.Context, cluster *v1.Cluster) error
 	OnUpdate(ctx context.Context, cluster *v1.Cluster) error
@@ -339,6 +341,10 @@ func (p *DelegateProvider) OnFilter(ctx context.Context, cluster *platformv1.Clu
 	return true
 }
 
+func (p *DelegateProvider) NeedUpdate(old, new *platformv1.Cluster) bool {
+	return false
+}
+
 func (p *DelegateProvider) getNextConditionType(conditionType string, handlers []Handler) string {
 	var (
 		i       int

pkg/platform/provider/machine/interface.go

@@ -51,7 +51,17 @@ const (
 type Provider interface {
 	Name() string
 
+	APIProvider
+	ControllerProvider
+}
+
+type APIProvider interface {
 	Validate(machine *platform.Machine) field.ErrorList
+}
+
+type ControllerProvider interface {
+	// NeedUpdate could be implemented by user to judge whether machine need update or not.
+	NeedUpdate(old, new *platformv1.Machine) bool
 
 	PreCreate(machine *platform.Machine) error
 	AfterCreate(machine *platform.Machine) error
@@ -213,6 +223,10 @@ func (p *DelegateProvider) OnDelete(ctx context.Context, machine *platformv1.Mac
 	return nil
 }
 
+func (p *DelegateProvider) NeedUpdate(old, new *platformv1.Machine) bool {
+	return false
+}
+
 func (p *DelegateProvider) getNextConditionType(conditionType string) string {
 	var (
 		i       int